fix: ensure Slurm scheduler initializes independently of gRPC connection#1
Open
fluidnumerics-joe wants to merge 1 commit intomainfrom
Open
fix: ensure Slurm scheduler initializes independently of gRPC connection#1fluidnumerics-joe wants to merge 1 commit intomainfrom
fluidnumerics-joe wants to merge 1 commit intomainfrom
Conversation
The Slurm scheduler (file-based) was initialized after gRPC client setup in Init(). If the gRPC connection to the GPU agent service failed, initalizeScheduler() was never called, leaving slurmScheduler as nil. During reconnect cycles, Close() would destroy the existing Slurm client, and if Init() failed again at initclients(), the Slurm data was permanently lost - causing empty job_id, job_user, job_partition labels in Prometheus metrics. Changes: - Move initalizeScheduler() before initclients() in Init() so the Slurm scheduler is always created regardless of gRPC connection state - Make scheduler init failure non-fatal (log and continue) - Preserve Slurm scheduler across reconnect() cycles to avoid losing accumulated workload data - Add test verifying Slurm labels flow into Prometheus label output - Add test verifying Slurm scheduler survives reconnect cycles https://claude.ai/code/session_017EwiweAXuPWUcAgisyuuBk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Slurm scheduler (file-based) was initialized after gRPC client setup in Init(). If the gRPC connection to the GPU agent service failed, initalizeScheduler() was never called, leaving slurmScheduler as nil. During reconnect cycles, Close() would destroy the existing Slurm client, and if Init() failed again at initclients(), the Slurm data was permanently lost - causing empty job_id, job_user, job_partition labels in Prometheus metrics.
Changes:
https://claude.ai/code/session_017EwiweAXuPWUcAgisyuuBk