This repository was archived by the owner on Feb 3, 2025. It is now read-only.
[BUGFIX] only register (Sub)PageLanguageOverlayProvider if pagesLanguageConfigurationOverlay is activated#350
Open
franzkugelmann wants to merge 3 commits intoFluidTYPO3:developmentfrom
Conversation
…ageConfigurationOverlay is activated
NamelessCoder
approved these changes
Feb 22, 2017
Member
|
I did a little change to make sure the providers only load when the option is explicitly enabled. Honestly, I thought these providers were already excluded from loading when the option was off - it definitely isn't the intention to have those running if you disable that option! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If setting
pagesLanguageConfigurationOverlay = 0then in this project all fluidpages configuration is done only in the default language. Thus the (Sub)PageLanguageOverlayProvider is not needed at all and in fact causes an errorif the page_language_overlay record is edited.
I am not 100% sure if this assumption is correct, but solves the problem in my instance without creating other issues, as far as i can see.