Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Classes/Controller/AbstractFluxController.php
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ protected function resolveView(): ViewInterface
/**
* @return \Psr\Http\Message\ResponseInterface|Response
*/
protected function createHtmlResponse(string $html = null)
protected function createHtmlResponse(?string $html = null)
{
if (method_exists($this, 'htmlResponse')) {
return parent::htmlResponse($html);
Expand Down
2 changes: 1 addition & 1 deletion Classes/Form/Transformation/FormDataTransformer.php
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public function __construct(FlexFormService $flexFormService, DataTransformerReg
*/
public function convertFlexFormContentToArray(
string $flexFormContent,
Form $form = null,
?Form $form = null,
?string $languagePointer = 'lDEF',
?string $valuePointer = 'vDEF'
): array {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ abstract class AbstractChimeraConfigurationManager extends ConfigurationManager

public function getConfiguration(
string $configurationType,
string $extensionName = null,
string $pluginName = null
?string $extensionName = null,
?string $pluginName = null
): array {
$configurationManager = $this->resolveConfigurationManager();

Expand Down
2 changes: 1 addition & 1 deletion Classes/Integration/Overrides/LocalizationController.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class LocalizationController extends \TYPO3\CMS\Backend\Controller\Page\Localiza
*/
public function getRecordLocalizeSummary(
ServerRequestInterface $request,
ResponseInterface $response = null
?ResponseInterface $response = null
): ResponseInterface {
$params = $request->getQueryParams();
if (!isset($params['pageId'], $params['destLanguageId'], $params['languageId'])) {
Expand Down
6 changes: 3 additions & 3 deletions Classes/Integration/PreviewView.php
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ class PreviewView extends TemplateView
protected ConfigurationManagerInterface $configurationManager;
protected WorkspacesAwareRecordService $workspacesAwareRecordService;

public function __construct(RenderingContextInterface $context = null)
public function __construct(?RenderingContextInterface $context = null)
{
parent::__construct($context);

Expand Down Expand Up @@ -94,7 +94,7 @@ public function getPreview(ProviderInterface $provider, array $row, bool $withou
)['preview'];
}

protected function getPreviewOptions(Form $form = null): array
protected function getPreviewOptions(?Form $form = null): array
{
if (!is_object($form) || !$form->hasOption(PreviewOption::PREVIEW)) {
return [
Expand All @@ -116,7 +116,7 @@ protected function getOptionToggle(array $options = []): bool
return (boolean) ($options[PreviewOption::TOGGLE] ?? true);
}

protected function renderPreviewSection(ProviderInterface $provider, array $row, Form $form = null): ?string
protected function renderPreviewSection(ProviderInterface $provider, array $row, ?Form $form = null): ?string
{
$templatePathAndFilename = $provider->getTemplatePathAndFilename($row);
if (!$templatePathAndFilename) {
Expand Down
4 changes: 2 additions & 2 deletions Classes/Provider/ProviderResolver.php
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public function resolvePageProvider(array $row): ?ProviderInterface
public function resolvePrimaryConfigurationProvider(
?string $table,
?string $fieldName,
array $row = null,
?array $row = null,
?string $extensionKey = null,
array $interfaces = [ProviderInterface::class]
) {
Expand All @@ -66,7 +66,7 @@ public function resolvePrimaryConfigurationProvider(
public function resolveConfigurationProviders(
?string $table,
?string $fieldName,
array $row = null,
?array $row = null,
?string $extensionKey = null,
array $interfaces = [ProviderInterface::class]
) {
Expand Down
14 changes: 7 additions & 7 deletions Tests/Mock/ExpressionBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -112,37 +112,37 @@ public function bitAnd(string $fieldName, int $value): string
return __FUNCTION__;
}

public function min(string $fieldName, string $alias = null): string
public function min(string $fieldName, ?string $alias = null): string
{
return __FUNCTION__;
}

public function max(string $fieldName, string $alias = null): string
public function max(string $fieldName, ?string $alias = null): string
{
return __FUNCTION__;
}

public function avg(string $fieldName, string $alias = null): string
public function avg(string $fieldName, ?string $alias = null): string
{
return __FUNCTION__;
}

public function sum(string $fieldName, string $alias = null): string
public function sum(string $fieldName, ?string $alias = null): string
{
return __FUNCTION__;
}

public function count(string $fieldName, string $alias = null): string
public function count(string $fieldName, ?string $alias = null): string
{
return __FUNCTION__;
}

public function length(string $fieldName, string $alias = null): string
public function length(string $fieldName, ?string $alias = null): string
{
return __FUNCTION__;
}

protected function calculation(string $aggregateName, string $fieldName, string $alias = null): string
protected function calculation(string $aggregateName, string $fieldName, ?string $alias = null): string
{
return __FUNCTION__;
}
Expand Down
14 changes: 7 additions & 7 deletions Tests/Mock/QueryBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@ public function count(string $item): self
return $this;
}

public function delete(string $delete, string $alias = null): self
public function delete(string $delete, ?string $alias = null): self
{
return $this;
}

public function update(string $update, string $alias = null): self
public function update(string $update, ?string $alias = null): self
{
return $this;
}
Expand Down Expand Up @@ -61,7 +61,7 @@ public function expr(): ExpressionBuilder
return $this->expressionBuilder;
}

public function createNamedParameter($value, $type = Connection::PARAM_STR, string $placeHolder = null): string
public function createNamedParameter($value, $type = Connection::PARAM_STR, ?string $placeHolder = null): string
{
return 'p';
}
Expand Down Expand Up @@ -91,7 +91,7 @@ public function addSelectLiteral(string ...$selects): self
return $this;
}

public function from(string $from, string $alias = null): self
public function from(string $from, ?string $alias = null): self
{
return $this;
}
Expand All @@ -111,7 +111,7 @@ public function setFirstResult(int $firstResult): self
return $this;
}

public function join(string $fromAlias, string $join, string $alias, string $condition = null): self
public function join(string $fromAlias, string $join, string $alias, ?string $condition = null): self
{
return $this;
}
Expand All @@ -136,12 +136,12 @@ public function groupBy(...$groupBy): self
return $this;
}

public function orderBy(string $fieldName, string $order = null): self
public function orderBy(string $fieldName, ?string $order = null): self
{
return $this;
}

public function addOrderBy(string $fieldName, string $order = null): self
public function addOrderBy(string $fieldName, ?string $order = null): self
{
return $this;
}
Expand Down
2 changes: 1 addition & 1 deletion Tests/Unit/Form/AbstractFormTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ protected function getObjectClassName(): string
/**
* @test
*/
public function canChainAllChainableSetters(array $chainPropertiesAndValues = null): FormInterface
public function canChainAllChainableSetters(?array $chainPropertiesAndValues = null): FormInterface
{
if (null === $chainPropertiesAndValues) {
$chainPropertiesAndValues = $this->chainProperties;
Expand Down