[FEATURE][BUG]: Fixes and improvements when using with follow_the_leader package #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rCamera - this broke nuanced render object and layer behavior in follow_the_leader. Instead, use toImageSync() on the RepaintBoundary.
… background to match existing behavior of FlexSceneLayout.
…ts that need a window boundary * Timeline lets you specify a * Timeline now offers a truly minimal item scaffold with no theming, background color, or padding
* Switched out map of goldens in layout API for a SceneLayoutContent data structure that includes goldens, description, etc - so that scene layouts can make more decisions about info to include in the final render
…as added to Gallery
|
FYI @angelosilvestre |
matthew-carroll
deleted the
fixes-and-improvements-when-using-with-follow-the-leader
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FEATURE][BUG]: Fixes and improvements when using with follow_the_leader package
spacinginGridGoldenSceneLayoutfollow_the_leader. Instead, usetoImageSync()on the existingRepaintBoundary.GridSceneLayoutto use default item decorator and background to match existing behavior ofFlexSceneLayout.itemSetuptoGalleryso that a single setup can be applied to all items.Galleryis given item constraints, it now sets itsphysicalSizeto match the max bounds.Timelinenow accepts a desiredwindowSizewhich it applies to thephysicalSizein the test.TimelineitemScaffoldto become the "standard" one, and then created a true "minimal"itemScaffoldthat makes no decisions about theme, background color, or padding.Timelineto say "builder" because that's more of what it is.