[Feature] - Added PixelSnapCenter, PixelSnapAlign, PixelSnapRow, PixelSnapColumn, PixelSnapFlex, and used them throughout the codebase (Resolves #65) #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lSnapColumn, PixelSnapFlex, and used them throughout the codebase (Resolves #65)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Feature] - Added PixelSnapCenter, PixelSnapAlign, PixelSnapRow, PixelSnapColumn, PixelSnapFlex, and used them throughout the codebase (Resolves #65)
These widgets force their children to sit on integer pixel values. Also, they optionally force their children to layout with integer pixel widths and heights.
I replaced all existing uses for
Rows,Columns,Aligns andCenters with these widgets. I also replaced the use of aTablewith rows and columns so that we could snap those children, too. This is important for Golden Scene's, to avoid placing a golden bitmap image on a partial pixel boundary, which would then anti-alias the sides and make it impossible to compare, even on the same machine.