Skip to content

Switch rendering to surface, decrease image size #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Switch rendering to surface, decrease image size #47

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9d70074
Switch rendering to surface, decrease image size
RossComputerGuy Jun 10, 2023
1246680
Make page size 1/5 of original scale amount
RossComputerGuy Jun 14, 2023
78ed723
Resize images in the image cache
RossComputerGuy Jun 14, 2023
1b5c395
Resize images with the fit policy
RossComputerGuy Jun 14, 2023
636b03b
Change page size scale back to 72
RossComputerGuy Jun 14, 2023
aaed7d9
Scale image to a width of 400
RossComputerGuy Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion example/android/app/src/main/kotlin/com/example/example/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ import io.flutter.embedding.android.FlutterActivity
import io.flutter.embedding.android.RenderMode

class MainActivity: FlutterActivity() {
override fun getRenderMode(): RenderMode = RenderMode.texture
override fun getRenderMode(): RenderMode = RenderMode.surface
}
7 changes: 6 additions & 1 deletion example/lib/pages_with_tiled_images/image_cache.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,9 +474,14 @@ class DocumentPageTileImagePainter implements ImagePainter {
Future<void> _paintImage(PageRegionRenderRequest request, TileIndex tileIndex) async {
final imageCompleter = Completer<ui.Image>();
final index = (tileIndex.col + tileIndex.row) % _imageAssets.length;
final imageStream = AssetImage(_imageAssets[index]).resolve(
final imageStream = ResizeImage(
AssetImage(_imageAssets[index]),
width: 1024,
height: 768,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is almost certainly still way too big, but should be better than the current implementation.

Ideally these sizes would be as close as possible to the resolution you will actually display the image at.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also probably only want to specify one dimension or use ResizeImagePolicy.fit (which is not the default)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I wasn't sure what values to use so I just chose that. When I tried it out, I got extra vertical whitespace.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, if you use fit it will use that as a bounding box - if you specify one dimension it'll automatically scale the other dimension to preserve the aspect ratio.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, I switched it to the fit policy.

).resolve(
const ImageConfiguration(),
);

final listener = ImageStreamListener((ImageInfo imageInfo, bool synchronousCall) {
imageCompleter.complete(imageInfo.image);
});
Expand Down
2 changes: 1 addition & 1 deletion example/lib/pages_with_tiled_images/main_page_list_images_inspector.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class PageListImagesInspectorDemo extends StatefulWidget {
}

class _PageListImagesInspectorDemoState extends State<PageListImagesInspectorDemo> with TickerProviderStateMixin {
static final _naturalPageSize = const Size(8.5, 11) * 72;
static final _naturalPageSize = const Size(8.5, 11) * 14.4;

final _pageViewportKey = GlobalKey();
late PageListViewportController _viewportController;
Expand Down