Skip to content

[static_shock_cli]: Handle SocketException when checking for Pub version (resolves #128) #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[static_shock_cli]: Handle SocketException when checking for Pub version (resolves #128) #131

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ffadce
static shock cli: handle socket exceptions when checking for pub version
suragch May 30, 2024
d4f7b7a
Merge branch 'Flutter-Bounty-Hunters:main' into main
suragch Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/static_shock_cli/lib/src/version_check.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import 'dart:io';

import 'package:args/command_runner.dart';
import 'package:mason_logger/mason_logger.dart';
import 'package:pub_semver/pub_semver.dart';
Expand All @@ -20,8 +22,13 @@ mixin PubVersionCheck on Command {

@override
Future<void> run() async {
final isUpToDate = await StaticShockCliVersion.isAtLeastUpToDateWithPub();
if (isUpToDate) {
try {
final isUpToDate = await StaticShockCliVersion.isAtLeastUpToDateWithPub();
if (isUpToDate) {
return;
}
} on SocketException {
log.warn('Unable to reach pub.dev. Skipping version check.');
return;
}

Expand Down