Skip to content

Conversation

BazinC
Copy link
Contributor

@BazinC BazinC commented Jul 5, 2024

This PR includes minor changes we would like to get shipped with #2038.

  • Enable providing custom edit request handlers by constructor
  • Enable providing the trigger tby constuctor (default to '@')
  • Make the removeSlackComposingTokenAttribution method public
  • Provide a way to set value on the SlackTagIndex
  • Replace print() statements with logger.
  • Remove 2 AssertionError thrown when running on Android. They lead to the editor stuck in an unusable state. Removed because the situation happen without encountering any edge case. Normal usage.

BazinC added 4 commits July 5, 2024 15:30
… it possible to change tagIndex value, make removeSlackComposingTokenAttribution public

(cherry picked from commit f73b177)
(cherry picked from commit aedb1a9)
(cherry picked from commit 7029e10)
@BazinC
Copy link
Contributor Author

BazinC commented Jul 5, 2024

@matthew-carroll let me know if it is possible to merge this into your branch

@matthew-carroll
Copy link
Contributor

Looks like a bunch of tests are failing. I'll make the changes you listed directly on my branch.

In general, there's no reason to put up a PR to change a branch that someone is already working on. In this case, I would have preferred that you just tell me what you want me to adjust.

@BazinC
Copy link
Contributor Author

BazinC commented Jul 8, 2024

Understood

@BazinC BazinC closed this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants