Skip to content

Fix Goldens - Option 1 #2183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fix Goldens - Option 1 #2183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7561d15
chore: remove strange platform setup
CillianMyles Jul 24, 2024
e8f0134
chore: update goldens from Linux machine
CillianMyles Jul 24, 2024
a8d7214
chore: regenerate toolbar goldens using docker image
CillianMyles Jul 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified .../super_textfield/goldens/super_textfield_ios_toolbar_pointing_down_expanded.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...ns/super_textfield/goldens/super_textfield_ios_toolbar_pointing_up_expanded.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 2 additions & 4 deletions super_editor/test_goldens/super_textfield/super_textfield_toolbar_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,14 @@ import '../test_tools_goldens.dart';

void main() {
group('SuperTextField', () {
testGoldensOnAndroid('displays toolbar pointing down for expanded selection', (tester) async {
testGoldensOniOS('displays toolbar pointing down for expanded selection', (tester) async {
// Pumps a widget tree with a SuperTextField at the bottom of the screen.
await _pumpSuperTextfieldToolbarTestApp(
tester,
child: Positioned(
bottom: 50,
child: _buildSuperTextField(
text: 'Arrow pointing down',
configuration: SuperTextFieldPlatformConfiguration.iOS,
),
),
);
Expand Down Expand Up @@ -57,13 +56,12 @@ void main() {
);
});

testGoldensOnAndroid('displays toolbar pointing up for expanded selection', (tester) async {
testGoldensOniOS('displays toolbar pointing up for expanded selection', (tester) async {
// Pumps a widget tree with a SuperTextField at the top of the screen.
await _pumpSuperTextfieldToolbarTestApp(
tester,
child: _buildSuperTextField(
text: 'Arrow pointing up',
configuration: SuperTextFieldPlatformConfiguration.iOS,
),
);

Expand Down