Skip to content

[super_editor_markdown] Fix parsing loose tasks list #2763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: stable
Choose a base branch
from
Open

[super_editor_markdown] Fix parsing loose tasks list #2763

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69e0826
fix: parsing loose tasks list
raulmabe-labhouse Jul 31, 2025
c70df66
chore: undo code formatting
raulmabe-labhouse Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion super_editor_markdown/lib/src/markdown_to_document_parsing.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,17 +390,28 @@ class _MarkdownToDocument implements md.NodeVisitor {

void _addTask(md.Element element) {
bool checked = false;
var text = '';
if (element.children != null && //
element.children!.isNotEmpty &&
element.children!.first is md.Element &&
(element.children!.first as md.Element).tag == 'input') {
checked = (element.children!.first as md.Element).attributes['checked'] == 'true';
text = element.textContent;
} else if (element.children != null &&
element.children!.isNotEmpty &&
(element.children!.first as md.Element).tag == 'p' &&
(element.children!.first as md.Element).children != null &&
(element.children!.first as md.Element).children!.isNotEmpty &&
((element.children!.first as md.Element).children!.first as md.Element).tag == 'input') {
checked = ((element.children!.first as md.Element).children!.first as md.Element).attributes['checked'] == 'true';
var [_, ...rest] = (element.children!.first as md.Element).children!;
text = rest.map((e) => e.textContent).join('\n');
}

_content.add(
TaskNode(
id: Editor.createNodeId(),
text: _parseInlineText(element.textContent),
text: _parseInlineText(text),
isComplete: checked,
),
);
Expand Down