[SuperEditor] - Report correct SelecitonChangeType when restoring selection on re-focus (Resolves #2792) #2887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ection on re-focus (Resolves #2792)
matthew-carroll
deleted the
2792_fix-selection-change-type-when-restoring-selection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SuperEditor] - Report correct SelecitonChangeType when restoring selection on re-focus (Resolves #2792)
Previously we were always reporting
placeCaretwhen re-storing selection on re-focus. But when we restore an expanded selection, this change type is incorrect, and it was blowing up theStableTagsPlugin, which requires correct change types for selection changes.