Skip to content

Conversation

pinkeshmars
Copy link
Collaborator

@pinkeshmars pinkeshmars commented Aug 7, 2024

Description

  1. Alerts & Dialogs
  2. PDFviewer
  3. Bottom Sheet
  4. Audio widgets (player, record audio, play stop sound)
  5. Biometric action

Linear ticket and magic word Fixes DEVR-573

Type of change

  • Typo fix
  • New feature
  • Enhancement to current docs
  • Removed outdated references
  • Update assets

@pinkeshmars pinkeshmars requested a review from PoojaB26 August 7, 2024 10:58
@pinkeshmars pinkeshmars changed the title Pinkesh/missing topics 2 1 Pinkesh/missing topics 2.1 Aug 7, 2024
@github-actions github-actions bot requested a review from leighajarett August 7, 2024 10:59
@pinkeshmars pinkeshmars changed the title Pinkesh/missing topics 2.1 Missing topics 2.1 Aug 7, 2024
@pinkeshmars pinkeshmars removed the request for review from leighajarett August 7, 2024 11:00
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Collaborator

@PoojaB26 PoojaB26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit changes. Please fix them and then you can merge.


- **Informational Dialog:** To show some information the user should be aware of before interacting with the app. Contains only a single action button.
- **Confirm Dialog:** This dialog can contain two action buttons. It can trigger the subsequent action based on whether a user confirms the action. It can also be used before performing any non-revertable user action, for example, before deleting a user account.
- **Custom Dialog**: This is a fully customizable dialog that you can create using [components](../../ui/components/overview.md).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link doesnt work.

@@ -0,0 +1,199 @@
---
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check the component URLs, they dont link to anything.

3. **Disabled, pause**: This stops the audio player as soon as the app goes in the background.

:::info
By default, every AudioPlayer widget added to the project will show sample audio from the internet.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
By default, every AudioPlayer widget added to the project will show sample audio from the internet.
By default, every AudioPlayer widget added to the project will play a sample audio file from a network URL.


Follow the steps below to add an action that opens the bottom sheet:

1. Create a bottom sheet [component](../../resources/ui/components/overview.md). Tip: you can also create one from the 'BottomSheet' templates.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create this tip into an admonition. And then also link "create components from templates" section under components.

@pinkeshmars
Copy link
Collaborator Author

All review comments addressed!

@pinkeshmars pinkeshmars merged commit 8a840b9 into main Aug 8, 2024
@PoojaB26 PoojaB26 deleted the pinkesh/missing-topics-2-1 branch August 13, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants