-
Notifications
You must be signed in to change notification settings - Fork 110
Missing topics 2.4 #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing topics 2.4 #118
Conversation
…umentation into pinkesh/missing-topics-2-4
|
@@ -0,0 +1,287 @@ | |||
--- | |||
slug: my-organization |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @pinkeshmars, I think this should be part of FF UI directory itself. Since this is significant for teams plan. Can we please move this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! moved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested some major changes, please look into it, thanks!
docs/intro/ff-ui/dashboard.md
Outdated
When you duplicate a project containing the Firebase setup, you must delete the config files in your duplicated project and complete a new [**Firebase setup**](../../ff-integrations/firebase/connect-to-firebase-setup.md) for your project. | ||
::: | ||
|
||
## Dark/Light mode switch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these points should be in single bullet points instead. There is too much of wasted space. And more scrolling is required to compare text and image.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree! done.
@@ -276,3 +275,44 @@ conflict with others. Failing to do so may keep on updating the common *lastCach | |||
|
|||
::: | |||
|
|||
### Clear Query Cache [Action] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this should be h2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought to put it under H3 to make it look more organized since its parent topic is 'Backend Query Caching' only.
|
||
:::warning | ||
At present, testing this action isn't possible in Test mode, but you can use the Run mode for this purpose. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know the reason why? Can we add that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No Pooja, I am not aware of the reason. Maybe we can ask the eng team to clarify on this!
<p></p> | ||
|
||
### Adding Copy to Clipboard [Action] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this entire page, I feel it is redundant to add name of action and adding a H3 called "Adding Action[Action]"
Can we just remove all h3 and just keep Action name [Action] and go straight into intro + how to? If you see the summary on the right, it looks very repetitive. If you agree, please change for the entire page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya make sense. Updated now!
Hi @PoojaB26 review comments are addressed and ready to review again. Thanks! |
…umentation into pinkesh/missing-topics-2-4
docs/intro/ff-ui/dashboard.md
Outdated
|
||
- **Notifications Center**: The notification center simplify how you manage comments and invites across various projects. It conveniently centralizes all your project communications. And when you're ready to address a comment, simply tap on it, and you'll be taken directly to the relevant section of the project. | ||
|
||
- **My organization** From [here](my-organization.md), you can share custom code, assets, design systems, and APIs between your team users and across projects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's avoid saying "here" as much as possible. 1. not good for search indexing, and 2. can easily be replaced by the name for better context. This applies to callout links too.
E.g
avoid: "To know more about widgets, see here"
instead: "Learn more about widgets and widget trees." And add links to the main words itself.
I'll add this to style guide too. See this commit to see how we can approach such sections.
Topics covered
Linear ticket and magic word Fixes DEVR-573
Type of change