Skip to content

Updated App Store deployment info #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 15, 2024

Conversation

pinkeshmars
Copy link
Collaborator

@pinkeshmars pinkeshmars commented Oct 9, 2024

Description

Updated app store deployment info

Linear ticket and magic word Fixes DEVR-574
Fixes DEVR-579
Fixes DEVR-621

Type of change

  • Typo fix
  • New feature
  • Enhancement to current docs
  • Removed outdated references
  • Update assets

@pinkeshmars pinkeshmars requested a review from PoojaB26 October 9, 2024 10:49
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Collaborator

@PoojaB26 PoojaB26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly some content fixes required at few places. Please fix them and then we can merge.


Please follow these steps to create a Bundle ID:
To create a Bundle ID, visit the [**Certificates, IDs & Profiles**](https://idmsa.apple.com/IDMSWebAuth/signin?appIdKey=891bd3417a7776362562d2197f89480a8547b108fd934911bcbea0110d07f757&path=%2Faccount%2Fresources%2Fcertificates%2Flist&rv=1) page, add a new **App ID**, and provide these details:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the URL has the app id key, is that expected?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Thanks for catching this.

1. If you haven't added the Github repo yet, you can do so using the instructions [here](../exporting-code/push-to-github.md).
:::tip
You also have the option to [**Deploy apps from your GitHub repository**](deploy-from-github.md).
:::
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would suggest expanding this tip and say when would they need to deploy apps from github, like it can still be 2 sentences but something like, " if you like to manage the deployment outside of Flutterflow...." or something around, have your own CI/CD pipeline via github, manage the deployment outside of FF etc, basically give them a short reason why they need to consider this option.

Same comment for Android page. Change at both places please.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, that makes sense.

keywords: [Apple App Store, Google Play Store, Deployment, GitHub]
---

You can deploy your FlutterFlow app directly from a GitHub repository. This is especially useful when you are managing your app’s code on GitHub. Managing code on GitHub enables you to add custom features or advanced functionality that may not be fully supported by FlutterFlow's capabilities.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we mention first that if their flutterflow project is connected to a github repository, then the generated code can be pushed to the github repository and devs can manage deployment from the same repo instead of FF.

I'm also not sure about this line: Managing code on GitHub enables you to add custom features or advanced functionality that may not be fully supported by FlutterFlow's capabilities.

like just mention about the added functionalities that can be added when the genrated code is managed in github and lets end there?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya, updated it. and removed the 'Managing code on GitHub enables you to ...' as the benefits are very well explained just below it.

@pinkeshmars pinkeshmars merged commit c7fd0b8 into main Oct 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants