Skip to content

Fix Google Login + Place picker links + Referrals #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 15, 2024

Conversation

pinkeshmars
Copy link
Collaborator

@pinkeshmars pinkeshmars commented Oct 10, 2024

Description

Fix Google Login + Place picker links

Linear ticket and magic word Fixes DEVR-623
Fixes DEVR-645
Fixes DEVR-643

Type of change

  • Typo fix
  • New feature
  • Enhancement to current docs
  • Removed outdated references
  • Update assets

@pinkeshmars pinkeshmars requested a review from PoojaB26 October 10, 2024 11:09
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@pinkeshmars pinkeshmars changed the title Fix Google Login + Place picker links Fix Google Login + Place picker links + Referrals Oct 11, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we shouldnt use the link with beta, may confuse users, please redo the screenshots from app.ff.io

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link
Collaborator

@PoojaB26 PoojaB26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit changes required.

And replace the images with app.ff.io links please

Authentication**) action.
- Set Auth Provider to Google.
3. Set **Auth Provider** to **Google**.
4. Enable **Create User Document** and set the **Collection** to **users**. After successful login, this will insert the user's details, such as email, name, and photo, into the *users* collection. If you haven’t already, see how to [create *users* collection](auth-initial-setup.md#creating-the-users-collection). **Note** that, If a user already exists, it won't add details again.
Copy link
Collaborator

@PoojaB26 PoojaB26 Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
4. Enable **Create User Document** and set the **Collection** to **users**. After successful login, this will insert the user's details, such as email, name, and photo, into the *users* collection. If you haven’t already, see how to [create *users* collection](auth-initial-setup.md#creating-the-users-collection). **Note** that, If a user already exists, it won't add details again.
4. Enable **Create User Document** and set the **Collection** to **users**. After successful login, this will insert the user's details, such as email, name, and photo, into the *users* collection. **Note** that, if a user exists already, it won't add the details again.
If you haven’t already, see how to [create *users* collection](auth-initial-setup.md#creating-the-users-collection).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@pinkeshmars
Copy link
Collaborator Author

pinkeshmars commented Oct 15, 2024

@PoojaB26 Review comments addressed. Merging it.

@pinkeshmars pinkeshmars merged commit 7396b20 into main Oct 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants