Skip to content

Updated AdMob Integrations #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 4, 2024
Merged

Updated AdMob Integrations #187

merged 9 commits into from
Nov 4, 2024

Conversation

pinkeshmars
Copy link
Collaborator

@pinkeshmars pinkeshmars commented Oct 22, 2024

Description

Updated AdMob Integrations

Linear ticket and magic word
Fixes DEVR-357
Fixes DEVR-630

Type of change

  • Typo fix
  • New feature
  • Enhancement to current docs
  • Removed outdated references
  • Update assets

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions bot requested a review from PoojaB26 October 22, 2024 08:24
Copy link
Collaborator

@PoojaB26 PoojaB26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need few fixes.

Also, I know we mentioned about fixing the looping feature of Arcades? Like stopping the Arcade at the end of the slides and let users restart it. I see all the arcades here are looped as soon as the last slide is clicked. If we found any solution, can we apply them here?


After adding the keys, you can find the instructions to display the ad on below pages:
Below are some AdMob settings (under **Settings and Integrations** menu) that you might need to configure based on your app and target audience.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A screenshot from Settings page would have been useful.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added!

<div style={{
position: 'relative',
paddingBottom: 'calc(56.67989417989418% + 41px)', // Keeps the aspect ratio and additional padding
height: 0,
width: '100%'}}>
<iframe
src="https://demo.arcade.software/PBkC8jgpGHT2zrPhl5yh?embed&show_copy_link=true"
src="https://demo.arcade.software/vlm11muoQuU7YRS2AzQW?embed&show_copy_link=true"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this Arcade, there is an info about ad banners having a default dimension of X. I think that info should exist out of Arcade as an admonition .

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, added into info admonition.


### 1. Adding AdBanner widget
The **AdBanner** widget displays advertisement banners within your app. It can feature text, images, and rich media, including video ads.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any example image that includes adbanners in the ecommerce app?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, added one inside the tip admonition.


The steps to display an interstitial ad are as follows:
1. **Use Test Ads During Development**: Always enable Test Ads during development to avoid invalid traffic and protect your AdMob account from being flagged or banned.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They should be bullet points and not numbered. Fix for all the best practices below this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, fixed.

@PoojaB26
Copy link
Collaborator

PoojaB26 commented Nov 1, 2024

Hey @pinkeshmars it seems the diagrams have started using pointed arrows instead of bullet arrows, can you please fix the arrows and to maintain consistency, not use pointed arrows anywhere (other than very special circumstances like flowcharts). I see this being used more lately, please go to Figma and check your last few diagrams and fix them and update the files in this PR (even if its not admob related, for example for new feature release docs)

@pinkeshmars
Copy link
Collaborator Author

Need few fixes.

Also, I know we mentioned about fixing the looping feature of Arcades? Like stopping the Arcade at the end of the slides and let users restart it. I see all the arcades here are looped as soon as the last slide is clicked. If we found any solution, can we apply them here?

Yes, we initially enabled the stepper to help users track their progress, so if they start from the first step, they’ll have a clear indication of where they are. However, it’s not a perfect solution. After exploring more options in Arcade, I found that we can resolve this by setting the hotspot's 'Destination' to 'This Step'. All arcades on this page are fixed now.

Please note that this issue only occurs when the last step contains a hotspot. We’ll need to apply this solution for all the arcades. We can discuss further how we should approach it.

Hey @pinkeshmars it seems the diagrams have started using pointed arrows instead of bullet arrows, can you please fix the arrows and to maintain consistency, not use pointed arrows anywhere (other than very special circumstances like flowcharts). I see this being used more lately, please go to Figma and check your last few diagrams and fix them and update the files in this PR (even if its not admob related, for example for new feature release docs)

Sure, other images are for localization, which is WIP, and streaming Supabase query, which is not merged yet, so I shall update in that PR only.

@pinkeshmars
Copy link
Collaborator Author

@PoojaB26 this is ready to review again.

@PoojaB26 PoojaB26 merged commit 02ed547 into main Nov 4, 2024
1 check passed
@PoojaB26 PoojaB26 deleted the pinkesh/update-ads branch November 4, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants