-
Notifications
You must be signed in to change notification settings - Fork 105
Updated AdMob Integrations #187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need few fixes.
Also, I know we mentioned about fixing the looping feature of Arcades? Like stopping the Arcade at the end of the slides and let users restart it. I see all the arcades here are looped as soon as the last slide is clicked. If we found any solution, can we apply them here?
|
||
After adding the keys, you can find the instructions to display the ad on below pages: | ||
Below are some AdMob settings (under **Settings and Integrations** menu) that you might need to configure based on your app and target audience. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A screenshot from Settings page would have been useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added!
<div style={{ | ||
position: 'relative', | ||
paddingBottom: 'calc(56.67989417989418% + 41px)', // Keeps the aspect ratio and additional padding | ||
height: 0, | ||
width: '100%'}}> | ||
<iframe | ||
src="https://demo.arcade.software/PBkC8jgpGHT2zrPhl5yh?embed&show_copy_link=true" | ||
src="https://demo.arcade.software/vlm11muoQuU7YRS2AzQW?embed&show_copy_link=true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this Arcade, there is an info about ad banners having a default dimension of X. I think that info should exist out of Arcade as an admonition .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, added into info admonition.
|
||
### 1. Adding AdBanner widget | ||
The **AdBanner** widget displays advertisement banners within your app. It can feature text, images, and rich media, including video ads. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any example image that includes adbanners in the ecommerce app?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, added one inside the tip admonition.
docs/ff-integrations/ads/admob.md
Outdated
|
||
The steps to display an interstitial ad are as follows: | ||
1. **Use Test Ads During Development**: Always enable Test Ads during development to avoid invalid traffic and protect your AdMob account from being flagged or banned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They should be bullet points and not numbered. Fix for all the best practices below this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, fixed.
Hey @pinkeshmars it seems the diagrams have started using pointed arrows instead of bullet arrows, can you please fix the arrows and to maintain consistency, not use pointed arrows anywhere (other than very special circumstances like flowcharts). I see this being used more lately, please go to Figma and check your last few diagrams and fix them and update the files in this PR (even if its not admob related, for example for new feature release docs) |
Yes, we initially enabled the stepper to help users track their progress, so if they start from the first step, they’ll have a clear indication of where they are. However, it’s not a perfect solution. After exploring more options in Arcade, I found that we can resolve this by setting the hotspot's 'Destination' to 'This Step'. All arcades on this page are fixed now. Please note that this issue only occurs when the last step contains a hotspot. We’ll need to apply this solution for all the arcades. We can discuss further how we should approach it.
Sure, other images are for localization, which is WIP, and streaming Supabase query, which is not merged yet, so I shall update in that PR only. |
@PoojaB26 this is ready to review again. |
Description
Updated AdMob Integrations
Linear ticket and magic word
Fixes DEVR-357
Fixes DEVR-630
Type of change