Rewrite File Handling #267

pinkeshmars · 2025-01-30T11:11:33Z

Description

Rewrite File Handling

Linear ticket and magic word Fixes DEVR-380
Fixes DEVR-815
Fixes DEVR-817

Type of change

bolt-new-by-stackblitz · 2025-01-30T11:11:37Z

Run & review this pull request in StackBlitz Codeflow.

PoojaB26 · 2025-02-10T06:32:48Z

@pinkeshmars Should the name still be "file handling" though? I wonder if people would understand "media-management" right away because its not a super popular term? I think thats why we made the first version be called File Handling directly.

pinkeshmars · 2025-02-11T05:21:06Z

@pinkeshmars Should the name still be "file handling" though? I wonder if people would understand "media-management" right away because its not a super popular term? I think thats why we made the first version be called File Handling directly.

@PoojaB26 Updated back to 'File Handling' everywhere.

# Conflicts: # firebase.json

PoojaB26

@pinkeshmars Added some comments and change requests. Apologies for the delay in reviewing it!

docs/ff-concepts/file-handling/uploading-files.md

PoojaB26 · 2025-02-24T19:41:17Z

docs/ff-concepts/file-handling/uploading-files.md

+</div>
+<p></p>
+
+### Configure Upload or Save Media [Action]


This is not an action, also dont think we need a header for configurations, just use a simple text header instead of h3. title can be just "configurations"

How about also removing "configurations" header? I have updated it so that it looks like a more natural flow. you can take a look and let me know.

docs/ff-concepts/file-handling/uploading-files.md

PoojaB26 · 2025-02-24T19:48:35Z

docs/ff-concepts/file-handling/uploading-files.md

+
+Here’s an example of how you can use this action to upload media to your server via an API:
+
+First, set the **Upload/Save Media** action with the **Local Upload (Widget State)** upload type. then, add the next action as an **API call** and select the API that will upload the file to your server. After the API call is complete, ensure your server returns the uploaded file's URL. Use this URL to save in the database or [display the uploaded image](displaying-media.md).


Same comment as before, less focus on the API part. You can add it as an additional example. But more focus on the bytes part and where all can we use the bytes object

one can be multipart APIs, constructing such an API (maybe a screenshot?)

and then calling API like your example,

then using the same local object to also upload to firebase/supabase so not just API,

maybe using the bytes for further processing like in custom code?

not all examples required but should show users all possible scenarios and then can show the above API example as one of the example.

Yes. added more example as you mentioned.

docs/ff-concepts/file-handling/displaying-media.md

docs/ff-concepts/file-handling/clear-delete-media.md

docs/ff-concepts/file-handling/download-file.md

Co-authored-by: Pooja Bhaumik <[email protected]>

PoojaB26 · 2025-03-03T18:55:34Z

@pinkeshmars As you update this PR, can you also add a video embed for this updated video somewhere? https://www.youtube.com/watch?v=cKDuIZNdbh8

Co-authored-by: Pooja Bhaumik <[email protected]>

pinkeshmars · 2025-03-07T06:31:07Z

Hey @PoojaB26 all review comments are addressed! you can take a look again. Thanks!

PoojaB26

Please fix the small requests and then we can merge.

docs/ff-concepts/file-handling/uploading-files.md

PoojaB26 · 2025-03-10T07:29:09Z

docs/ff-concepts/file-handling/displaying-media.md

+
+### Asset
+
+You can also display media files uploaded to your [**Assets**](../../generated-code/directory-structure.md#assets). Assets are resources such as images, videos, documents, fonts, and other files that you include in your project. To upload assets, click on **Media Assets** in the left-side navigation menu and add files directly from your device. Alternatively, you can directly upload and display files when configuring media widgets by clicking the upload icon.


I wouldnt reference assets generated code page here because the expectation is that this ref page would be the introduction to assets? rather add an admonition after this paragraph for people to see how assets are stored in generated code and then add the ref. but you should treat this section as THE introduction to assets so we shouldnt have to refer any other section.

ok, updated.

docs/ff-concepts/file-handling/displaying-media.md

PoojaB26 · 2025-03-10T07:32:01Z

docs/ff-concepts/file-handling/displaying-media.md

+
+:::tip[Generated Code]
+The AudioPlayer uses the [**assets_audio_player**](https://pub.dev/packages/assets_audio_player) package for mobile and [**assets_audio_player_web**](https://pub.dev/packages/assets_audio_player_web) for web.
+:::


assets package already uses the web package so we dont think we need to mention that here, because it internally uses the web package already. correct me if i'm wrong!

Yes, you are right! Actually after adding audio player widget to the project, I saw both packages got added to the pubspec file, so I added them directly.

PoojaB26 · 2025-03-10T07:34:34Z

docs/ff-concepts/file-handling/displaying-media.md

+- [**video_player**](https://pub.dev/packages/video_player): Provides core functionality for video playback from assets or network sources.
+- [**video_player_android**](https://pub.dev/packages/video_player_android): Ensures smooth playback specifically for Android devices.
+- [**video_player_avfoundation**](https://pub.dev/packages/video_player_avfoundation): Integrates with Apple's AVFoundation framework for playback on iOS devices.
+- [**video_player_web**](https://pub.dev/packages/video_player_web): Enables video playback support for web browsers.


Same comment as before, it uses these packages internally, so we only need to mention the main package.

ya, no problem.

Co-authored-by: Pooja Bhaumik <[email protected]>

pinkeshmars added 2 commits January 30, 2025 14:04

File handling to media management rewrite

48042cb

Removed old file handling content and added redirects

5a6d29e

pinkeshmars requested a review from PoojaB26 January 30, 2025 11:11

pinkeshmars and others added 2 commits February 11, 2025 10:19

Merge branch 'main' into rewrite/media-management

b8353d8

Changed to 'File Handling'

aabbbe5

pinkeshmars changed the title ~~Rewrite Media Management~~ Rewrite File Handling Feb 11, 2025

Merge branch 'refs/heads/main' into rewrite/media-management

d34ad97

# Conflicts: # firebase.json

PoojaB26 requested changes Feb 24, 2025

View reviewed changes

pinkeshmars and others added 4 commits February 25, 2025 16:04

Apply suggestions from code review

931d355

Co-authored-by: Pooja Bhaumik <[email protected]>

Update docs/ff-concepts/file-handling/displaying-media.md

9741aa8

Co-authored-by: Pooja Bhaumik <[email protected]>

Merge branch 'main' into rewrite/media-management

0e5ce20

update local upload intro

918a86a

pinkeshmars and others added 8 commits March 5, 2025 11:46

added YT video

20fdc5d

address review comments part 1

3c73856

Address review comments part 2

49ac300

Update docs/ff-concepts/file-handling/displaying-media.md

86f1f5a

Co-authored-by: Pooja Bhaumik <[email protected]>

Update docs/ff-concepts/file-handling/displaying-media.md

8d17986

Co-authored-by: Pooja Bhaumik <[email protected]>

Address review comments part 3

0e2d99f

fix broken link

8d8f0a1

Address review comments part 4

1a23726

pinkeshmars and others added 2 commits March 7, 2025 15:54

Updated assets info

eed8130

Merge branch 'refs/heads/main' into rewrite/media-management

ad6aeda

PoojaB26 approved these changes Mar 10, 2025

View reviewed changes

pinkeshmars and others added 2 commits March 11, 2025 10:07

Apply suggestions from code review

0a5c4c8

Co-authored-by: Pooja Bhaumik <[email protected]>

Update docs/ff-concepts/file-handling/displaying-media.md

4e2a304

Co-authored-by: Pooja Bhaumik <[email protected]>

pinkeshmars and others added 2 commits March 11, 2025 10:09

Update docs/ff-concepts/file-handling/displaying-media.md

29313a1

Co-authored-by: Pooja Bhaumik <[email protected]>

Address review comments part 5

b3b6901

pinkeshmars merged commit 3f7c800 into main Mar 11, 2025
1 check passed


		Here’s an example of how you can use this action to upload media to your server via an API:

		First, set the Upload/Save Media action with the Local Upload (Widget State) upload type. then, add the next action as an API call and select the API that will upload the file to your server. After the API call is complete, ensure your server returns the uploaded file's URL. Use this URL to save in the database or [display the uploaded image](displaying-media.md).


		### Asset

		You can also display media files uploaded to your [Assets](../../generated-code/directory-structure.md#assets). Assets are resources such as images, videos, documents, fonts, and other files that you include in your project. To upload assets, click on Media Assets in the left-side navigation menu and add files directly from your device. Alternatively, you can directly upload and display files when configuring media widgets by clicking the upload icon.

Rewrite File Handling #267

Rewrite File Handling #267

Uh oh!

Conversation

pinkeshmars commented Jan 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Uh oh!

bolt-new-by-stackblitz bot commented Jan 30, 2025

Uh oh!

PoojaB26 commented Feb 10, 2025

Uh oh!

pinkeshmars commented Feb 11, 2025

Uh oh!

PoojaB26 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PoojaB26 commented Mar 3, 2025

Uh oh!

pinkeshmars commented Mar 7, 2025

Uh oh!

PoojaB26 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pinkeshmars commented Jan 30, 2025 •

edited

Loading