Puf - add docs for (enhanced) Firebase storage library #346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First commit of documentation for the Firebase Storage library.
Extract inline image into file in the right location and then link it there. I included both the original png and a derived svg in there, but am linking only the svg from the markdown as that one renders more readably.
|
|
PoojaB26
reviewed
May 16, 2025
There was a problem hiding this comment.
This looks a bit fabricated since the font is all wrong. Can we just use the png file?
PoojaB26
reviewed
May 16, 2025
There was a problem hiding this comment.
And the png file may be a bit low quality. Can this be a bit higher quality?
Remove image as one was too vague and the other too different. The same info is in the descriptions of the custom actions also.
|
👍
I removed the image altogether, since the info is in the action
descriptions anyway.
…On Fri, May 16, 2025 at 3:38 AM Pooja Bhaumik ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
On
docs/ff-integrations/storage/firebase-storage/imgs/storage-library-exports.png
<#346 (comment)>
:
And the png file may be a bit low quality. Can this be a bit higher
quality?
—
Reply to this email directly, view it on GitHub
<#346 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAG7BX3B54BT4JZQWRP5N4D26W52XAVCNFSM6AAAAAB5GYQH66VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQNBWGI2DINZZGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
com>
|
PoojaB26
approved these changes
May 20, 2025
docs/ff-integrations/storage/firebase-storage/storage-library.md
Outdated
Show resolved
Hide resolved
docs/ff-integrations/storage/firebase-storage/storage-library.md
Outdated
Show resolved
Hide resolved
docs/ff-integrations/storage/firebase-storage/storage-library.md
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds documentation for the new Firebase Storage library.
Linear ticket and magic word Fixes (part of) DEVR-796
Type of change