[DON'T MERGE] Test Tracker.jacobian on GPU #782
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can someone trigger the GitLab CI? Is it |
|
bors try |
tryBuild failed |
|
bors try |
`jacobian(softmax, ...)` didn't work because NNlib.jl defines the derivative by `∇softmax(Δ, xs) = ∇softmax!(similar(Δ), Δ, xs)` where `Δ` passed from `jacobian` was an array of bool. This is fixed in `jacobian` by creating float array.
tryBuild failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test that
Tracker.jacobianworks on GPU FluxML/Tracker.jl#33.I modified Manifest.toml in 221ab4c so that it points to the branch for FluxML/Tracker.jl#33 (using
add Tracker#remotes/cache/pull/33/head). This commit should be reverted once the new Tracker is released.