Skip to content

Conversation

camilodlt
Copy link

Hello,

Wouldn't it make more sense if by default the Adamw rule was different than Adam by making lambda != 0.0 (by default).

The default value in pytorch is 0.01.

I get that the value should be lower if we don't use couple=true, but since that value is the default it felt strange to have lambda=0.

I can make a test if you agree :)

PR Checklist

  • Tests are added
  • [x ] Documentation, if applicable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant