Skip to content

Attempt to fix #62 #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Attempt to fix #62 #63

wants to merge 2 commits into from

Conversation

mcabbott
Copy link
Member

This tries to fix #62 by using functor(typeof(x), dx) only for gradients, and functor(aux) for the tree of offsets made by destructure.

But it doesn't quite work, as for an array of arrays like x = [[1.0, 2.0]] the offset structure is something like o = [4] which is leaflike.

@mcabbott mcabbott marked this pull request as draft March 26, 2022 02:47
@jondeuce jondeuce mentioned this pull request Apr 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
gradients
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

destructure doesn't work correctly with certain functors
1 participant
@mcabbott