Skip to content

Re-allocate Buffer if the incoming eltypes don't match preallocated one #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Re-allocate Buffer if the incoming eltypes don't match preallocated one #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/destructure.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,13 +130,20 @@ function _grad!(x, dx, off, flat::AbstractVector)
foreach((xᵢ, dxᵢ, oᵢ) -> _grad!(xᵢ, dxᵢ, oᵢ, flat), x′, dx′, off′)
flat
end
function _grad!(x, dx, off::Integer, flat::AbstractVector)
function _grad!(x::T, dx::T, off::Integer, flat::AbstractVector) where T
@views flat[off .+ (1:length(x))] .+= vec(dx) # must visit all tied nodes
flat
end
_grad!(x, dx::Zero, off, flat::AbstractVector) = dx
_grad!(x, dx::Zero, off::Integer, flat::AbstractVector) = dx # ambiguity

function _grad!(x::T, dx::S, off::Integer, flat::AbstractVector) where {T, S}
flat = similar(dx, length(flat))
@views flat[off .+ (1:length(x))] .+= vec(dx) # must visit all tied nodes
flat
end


# These are only needed for 2nd derivatives:
function ChainRulesCore.rrule(::typeof(_grad!), x, dx, off, flat)
@warn "second derivatives of Restructure may not work yet, sorry!" maxlog=3
Expand Down