Skip to content

getindex for CuArray to fix repeated indices error #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

getindex for CuArray to fix repeated indices error #1131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5d58b06
getindex for CuArray
jgreener64 Dec 8, 2021
448ba91
Check for unique indices
jgreener64 Jan 5, 2022
fd5596a
Move to CUDA requires block
jgreener64 Jan 5, 2022
c951b0a
Broadcast on CPU
jgreener64 Feb 20, 2022
67069cb
Skip uniqueness check
jgreener64 Feb 22, 2022
167d500
update for changes on master
jgreener64 Aug 3, 2022
8e06259
test repeated indexing
jgreener64 Aug 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/lib/broadcast.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,3 +286,10 @@ using GPUArraysCore # replaces @require CUDA block, weird indenting to preserve

pull_block_vert(sz, Δ::AbstractGPUArray, A::Number) = @allowscalar Δ[sz]

∇getindex(x::T, inds::Tuple{AbstractArray{<:Integer}}) where {T <: AbstractGPUArray} = dy -> begin
inds1_cpu = Array(inds[1])
dx = zeros(eltype(dy), length(x))
dxv = view(dx, inds1_cpu)
dxv .= accum.(dxv, _droplike(Array(dy), dxv))
return _project(x, T(dx)), nothing
end
6 changes: 6 additions & 0 deletions test/cuda.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,3 +140,9 @@ end
@test_skip gradient((x,y) -> sum(vcat(x,y)), 1f0, r, 2f0, r)[2] isa CUDA.CuArray{Float32}
end

@testset "repeated indexing" begin
f(a) = sum(view(a, [1, 1, 2]))
a = CUDA.CuArray([1.0f0, 1.0f0, 1.0f0])
@test f(a) == 3.0f0
@test Array(gradient(f, a)[1]) == [2.0f0, 1.0f0, 0.0f0]
end