-
-
Notifications
You must be signed in to change notification settings - Fork 216
CompatHelper: bump compat for ForwardDiff to 1, (keep existing compat) #1563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CompatHelper: bump compat for ForwardDiff to 1, (keep existing compat) #1563
Conversation
f982280
to
50ae266
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flux failure is Reactant, see FluxML/Flux.jl#2596
DynamicPPL failure seems to be Aqua being confused about versions? cc @penelopeysm who wrote TuringLang/DynamicPPL.jl#775
1-element Vector{Base.PkgId}:
Zygote [e88e6eb3-aa80-5325-afca-941959d7151f]
Base.PkgId(Base.UUID("366bfd00-2699-11ea-058f-f148b4cae6d8"), "DynamicPPL") deps: Test Failed at /home/runner/.julia/packages/Aqua/epbUr/src/deps_compat.jl:60
Expression: isempty(result)
Evaluated: isempty(Base.PkgId[Base.PkgId(Base.UUID("e88e6eb3-aa80-5325-afca-941959d7151f"), "Zygote")])
Stacktrace:
[1] macro expansion
@ /opt/hostedtoolcache/julia/1.11.4/x64/share/julia/stdlib/v1.11/Test/src/Test.jl:679 [inlined]
[2] test_deps_compat(pkg::Base.PkgId, deps_type::String; broken::Bool, kwargs::@Kwargs{})
@ Aqua ~/.julia/packages/Aqua/epbUr/src/deps_compat.jl:60
[3] test_deps_compat
@ ~/.julia/packages/Aqua/epbUr/src/deps_compat.jl:55 [inlined]
[4] macro expansion
@ ~/.julia/packages/Aqua/epbUr/src/deps_compat.jl:41 [inlined]
[5] macro expansion
@ /opt/hostedtoolcache/julia/1.11.4/x64/share/julia/stdlib/v1.11/Test/src/Test.jl:1704 [inlined]
[6] test_deps_compat(pkg::Base.PkgId; check_julia::Bool, check_extras::Bool, check_weakdeps::Bool, kwargs::@Kwargs{})
@ Aqua ~/.julia/packages/Aqua/epbUr/src/deps_compat.jl:41
Hey @mcabbott - thanks for the ping! DynamicPPL's codebase doesn't import Zygote anywhere so I think when you Pkg.dev Zygote and it gets added to the Project.toml, Aqua rightly complains. You could either disable it by setting |
Ok, I see what Aqua is trying to say now, thanks. Mind making a PR removing this downstream test, if it's not useful? |
Yup, happy to! |
Can we get a release with this PR? |
Should already be out, JuliaRegistries/General#127749 |
the problem I was actually running into was that NonlinearSolve.jl is fixed to [email protected] (since the thunkening of 0.7 causes some type stability problems, see SciML/NonlinearSolve.jl#566). Would it be possible to release a new version of 0.6 with [email protected] compat? |
I know nothing about that package but the PR test failures look unrelated to Zygote?
It's certainly possible to start doing 0.6 backports but honestly I'd prefer that someone else volunteer the time. |
yeah the windows failures are unrelated, but the macos ones are related https://github.com/SciML/NonlinearSolve.jl/actions/runs/14180225226/job/39724441050?pr=566. I'd be happy to make the PR if that was helpful (but I don't have permissions to merge or release |
If you make a 0.6-backports branch, I can make the PR to target it. |
I made https://github.com/FluxML/Zygote.jl/tree/release-0.6 but please check I got the right place to branch off! |
You got it right. #1566 created |
This pull request changes the compat entry for the
ForwardDiff
package from0.10
to0.10, 1
.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.