Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the ForwardDiff package from 0.10 to 0.10, 1.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@DhairyaLGandhi DhairyaLGandhi force-pushed the compathelper/new_version/2025-03-26-17-44-29-034-00912257922 branch from f982280 to 50ae266 Compare March 26, 2025 17:44
Copy link
Member

@mcabbott mcabbott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flux failure is Reactant, see FluxML/Flux.jl#2596

DynamicPPL failure seems to be Aqua being confused about versions? cc @penelopeysm who wrote TuringLang/DynamicPPL.jl#775

1-element Vector{Base.PkgId}:
 Zygote [e88e6eb3-aa80-5325-afca-941959d7151f]
Base.PkgId(Base.UUID("366bfd00-2699-11ea-058f-f148b4cae6d8"), "DynamicPPL") deps: Test Failed at /home/runner/.julia/packages/Aqua/epbUr/src/deps_compat.jl:60
  Expression: isempty(result)
   Evaluated: isempty(Base.PkgId[Base.PkgId(Base.UUID("e88e6eb3-aa80-5325-afca-941959d7151f"), "Zygote")])

Stacktrace:
 [1] macro expansion
   @ /opt/hostedtoolcache/julia/1.11.4/x64/share/julia/stdlib/v1.11/Test/src/Test.jl:679 [inlined]
 [2] test_deps_compat(pkg::Base.PkgId, deps_type::String; broken::Bool, kwargs::@Kwargs{})
   @ Aqua ~/.julia/packages/Aqua/epbUr/src/deps_compat.jl:60
 [3] test_deps_compat
   @ ~/.julia/packages/Aqua/epbUr/src/deps_compat.jl:55 [inlined]
 [4] macro expansion
   @ ~/.julia/packages/Aqua/epbUr/src/deps_compat.jl:41 [inlined]
 [5] macro expansion
   @ /opt/hostedtoolcache/julia/1.11.4/x64/share/julia/stdlib/v1.11/Test/src/Test.jl:1704 [inlined]
 [6] test_deps_compat(pkg::Base.PkgId; check_julia::Bool, check_extras::Bool, check_weakdeps::Bool, kwargs::@Kwargs{})
   @ Aqua ~/.julia/packages/Aqua/epbUr/src/deps_compat.jl:41

@mcabbott mcabbott merged commit 23add62 into master Mar 26, 2025
9 of 13 checks passed
@mcabbott mcabbott deleted the compathelper/new_version/2025-03-26-17-44-29-034-00912257922 branch March 26, 2025 19:41
@penelopeysm
Copy link
Contributor

Hey @mcabbott - thanks for the ping! DynamicPPL's codebase doesn't import Zygote anywhere so I think when you Pkg.dev Zygote and it gets added to the Project.toml, Aqua rightly complains. You could either disable it by setting ENV["AQUA"] = "false" https://github.com/TuringLang/DynamicPPL.jl/blob/fb5413f482b962d97b6e4728d560297cd713c295/test/runtests.jl#L37-L38, or to be honest, I think the DPPL integration test can be removed. Our test suite hasn't had any serious Zygote tests for a while now so you wouldn't be gaining any information from it.

@mcabbott
Copy link
Member

Ok, I see what Aqua is trying to say now, thanks.

Mind making a PR removing this downstream test, if it's not useful?

@penelopeysm
Copy link
Contributor

Yup, happy to!

@oscardssmith
Copy link

Can we get a release with this PR?

@mcabbott
Copy link
Member

Should already be out, JuliaRegistries/General#127749

@oscardssmith
Copy link

the problem I was actually running into was that NonlinearSolve.jl is fixed to [email protected] (since the thunkening of 0.7 causes some type stability problems, see SciML/NonlinearSolve.jl#566). Would it be possible to release a new version of 0.6 with [email protected] compat?

@mcabbott
Copy link
Member

I know nothing about that package but the PR test failures look unrelated to Zygote?

ERROR: LoadError: IOError: unlink("C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\ReTestItemsTempLogsDirectory\\ReTestItems_setup_ForwardADTesting_9066141192731665113.log"): resource busy or locked (EBUSY)
Stacktrace:
  [1] uv_error
    @ .\libuv.jl:106 [inlined]

It's certainly possible to start doing 0.6 backports but honestly I'd prefer that someone else volunteer the time.

@oscardssmith
Copy link

yeah the windows failures are unrelated, but the macos ones are related https://github.com/SciML/NonlinearSolve.jl/actions/runs/14180225226/job/39724441050?pr=566. I'd be happy to make the PR if that was helpful (but I don't have permissions to merge or release

@oscardssmith
Copy link

If you make a 0.6-backports branch, I can make the PR to target it.

@mcabbott
Copy link
Member

I made https://github.com/FluxML/Zygote.jl/tree/release-0.6 but please check I got the right place to branch off!

@oscardssmith
Copy link

oscardssmith commented Mar 31, 2025

You got it right. #1566 created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants