Skip to content

WIP: Add support for ChainRules Composite type #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 38 commits into
base: chainrules_types
Choose a base branch
from
Open

WIP: Add support for ChainRules Composite type #806

wants to merge 38 commits into from

Conversation

mzgubic
Copy link
Collaborator

@mzgubic mzgubic commented Oct 9, 2020

No description provided.

@mzgubic
Copy link
Collaborator Author

mzgubic commented Oct 9, 2020 •
edited
Loading

From features.jl:98

ERROR: BoundsError: attempt to access (DoesNotExist(), DoesNotExist(), Composite{Any}(3, 2))
  at index [4]

(used to be (DoesNotExist(), DoesNotExist(), 3, 2) before switching)

I can't quite think of an elegant solution to this...

Should the code be changed such that the index i changes, or should the way gradindex deals with Composites be changed?
Or maybe Composite should be splatted?

@mcabbott mcabbott added the ChainRules adjoint -> rrule, and further integration label Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ChainRules adjoint -> rrule, and further integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mzgubic @mcabbott