Expand unthunk-tangent with more methods#28
Merged
ToucheSir merged 3 commits intoFluxML:masterfrom Jan 20, 2025
pxl-th:pxl-th/unthunk-tangent
Merged
Expand unthunk-tangent with more methods#28ToucheSir merged 3 commits intoFluxML:masterfrom pxl-th:pxl-th/unthunk-tangent
ToucheSir merged 3 commits intoFluxML:masterfrom
pxl-th:pxl-th/unthunk-tangent
Conversation
Member
Author
|
Ah... there's slight issue. |
Member
Author
|
If this is acceptable, I have opened a PR: |
2 tasks
Member
Author
|
Alternatively, we can move |
Member
Author
|
Or just move on with FluxML/Zygote.jl#1551 without making changes for now (and try getting rid of ZygoteRules in future PRs). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are moved over from Zygote:
https://github.com/FluxML/Zygote.jl/blob/a38a4a565b925723386d311938226e6e29a106c2/src/compiler/chainrules.jl#L3
PR Checklist