Skip to content

Allow for unthunk to return nothing #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow for unthunk to return nothing #35

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2501722
allow unthunk to return nothing
mcabbott Apr 9, 2025
d18ab25
Update src/adjoint.jl
mcabbott Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/adjoint.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ function gradm(ex, mut = false, keepthunks = false)
gradtuple = isclosure ? gradtuple0 : gradtuple1
gradtuplekw = isclosure ? gradtuple2 : gradtuple3
adj = @q @inline ZygoteRules.adjoint($(fargs...)) where $(Ts...) = $(esc(body))
maybe_unthunked_Δ = keepthunks ? :Δ : :(unthunk_tangent(Δ))
maybe_unthunk = keepthunks ? nothing : :(back(Δ::AbstractThunk) = back(unthunk_tangent(Δ)))
quote
$adj
@inline function ZygoteRules._pullback($cx, $f::$T, $(args...)) where $(Ts...)
Expand All @@ -69,7 +69,8 @@ function gradm(ex, mut = false, keepthunks = false)
back(::Nothing) = nothing
back(Δ::AbstractZero) = $gradtuple(ntuple(_ -> Δ, $(length(args))))
end)
back(Δ) = $gradtuple(_back($maybe_unthunked_Δ))
$maybe_unthunk
back(Δ) = $gradtuple(_back(Δ))
return y, back
end
@inline function ZygoteRules._pullback($cx, ::$kT, kw, $f::$T, $(args...)) where $(Ts...)
Expand All @@ -78,7 +79,8 @@ function gradm(ex, mut = false, keepthunks = false)
back(::Nothing) = nothing
back(Δ::AbstractZero) = $gradtuplekw(ntuple(_ -> Δ, $(length(args))))
end)
back(Δ) = $gradtuplekw(_back($maybe_unthunked_Δ))
$maybe_unthunk
back(Δ) = $gradtuplekw(_back(Δ))
return y, back
end
nothing
Expand Down
Loading