Prefer SMBIOS table to SMBIOS 3.0, if present and below 4G

[mintsuki]

This mirrors PR #70, done for similar reasons.

[FlyGoat]

SeaBIOS will only accept SMBIOS2.1.

https://github.com/coreboot/seabios/blob/b52ca86e094d19b58e2304417787e96b940e39c6/src/fw/csm.c#L176

[mintsuki]

Well, then we shouldn't be falling back to SMBIOS3 at all, no?

[FlyGoat]

It won't hurt in case we want to fix SeaBIOS at some point:-)

Also for SMBIOS we are unlikely to have ACPI 1.0 style compatibility issue.

[mintsuki]

Should be good now, I believe.

[FlyGoat]

Maybe commit message needs to be updated to reflect the change?

[mintsuki]

Maybe commit message needs to be updated to reflect the change?

I did update it, though :)

[FlyGoat]

Maybe commit message needs to be updated to reflect the change?

I did update it, though :)

Hmm, what I see is

[mintsuki]

What's the issue with that? What would you like the commit message to be?

Initially it was Prefer SMBIOS3 table to SMBIOS, if present and below 4G, and I changed it to that after we discussed what to change.

[FlyGoat]

@mintsuki Maybe it should be Prefer SMBIOS2.1 table to SMBIOS, if present and below 4G, as we are scanning for smbiosGuid first?

[mintsuki]

@FlyGoat I hope this is better.

[FlyGoat]

lgtm thanks