Upgrade createapp templates and specs to ESLint v10 flat config - #1365
Open
deepanshu44 wants to merge 2 commits into
Open
Upgrade createapp templates and specs to ESLint v10 flat config#1365deepanshu44 wants to merge 2 commits into
deepanshu44 wants to merge 2 commits into
Conversation
Author
|
In order to remove the errors that were triggered by the bash E2E test file, I've tried to modify the Previously, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @LoicPoullain 👋
Following up on PR #1357, this PR upgrades the
foal createappgenerator templates (packages/cli/templates/app/andspecs/app/) to ESLint v10 (Flat Config) and Prettier.🌟 Summary of Changes:
.eslintrc.jsintemplates/app/andspecs/app/with nativeeslint.config.mjsand.prettierrcso newly generated FoalTS projects ship with ESLint v10.package.jsonvariants to useeslintv10 (^10.0.0),typescript-eslintv8 (^8.0.0),prettier(^3.0.0), andeslint-config-prettier(^10.0.0).@foal/cli'screate-app-command.service.tsand its unit tests to copyeslint.config.mjsand.prettierrcwhen creating new apps.All CLI generator unit tests are passing cleanly (
295 passing). Let me know what you think.