Skip to content

Optimize code by removing redundant logic

e54a038
Select commit
Loading
Failed to load commit list.
Open

Feat: Add media output switcher support for original equipment manufacturers (OEMs) #635

Optimize code by removing redundant logic
e54a038
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Code Health Review (beta) failed Jan 3, 2026 in 42s

CodeScene PR Check

Quality Gate Failed

Gates Failed
Prevent hotspot decline (1 hotspot with Complex Method)
Enforce critical code health rules (1 file with Bumpy Road Ahead)

Gates Passed
1 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
Prevent hotspot decline Violations Code Health Impact
FullBottomSheet.kt 1 rule in this hotspot 5.76 → 5.73 Suppress
Enforce critical code health rules Violations Code Health Impact
SystemMediaControlResolver.kt 1 critical rule 9.24 Suppress

Quality Gate Profile: The Bare Minimum
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method FullBottomSheet.kt: FullBottomSheet.init 🔥
  • Bumpy Road Ahead SystemMediaControlResolver.kt: SystemMediaControlResolver.startSystemMediaControl

Annotations

Check warning on line 78 in app/src/main/java/org/akanework/gramophone/logic/utils/exoplayer/oem/SystemMediaControlResolver.kt

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Code Health Review (beta)

❌ New issue: Bumpy Road Ahead

SystemMediaControlResolver.startSystemMediaControl has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is 2 blocks per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 432 in app/src/main/java/org/akanework/gramophone/ui/components/FullBottomSheet.kt

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Code Health Review (beta)

❌ Getting worse: Complex Method

FullBottomSheet.init increases in cyclomatic complexity from 14 to 15, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.