Add option to limit concurrent uploads #381
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This only kind of works. If two WUs finish at the same time they will both upload at the same time. This prevents a download during an upload. |
Contributor
Author
|
That's intentional. By deferring downloads, it limits the chances of the upload failing. Users with extremely poor internet connections could set the max uploads to 0 so that a download is not attempted until the previous upload has finished. |
jcoffland
force-pushed
the
master
branch
2 times, most recently
from
0de19d9 to
cb9e314
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a configuration option,
max-uploads, to limit the maximum number of concurrent uploads. The default remains 3. A resource group will download a new WU only when the number of pending uploads falls below this value.Fixes #98