Refactor imports and styling by danelkay93 · Pull Request #14 · Folia-Labs/abyssal-tome

danelkay93 · 2025-11-29T12:01:57Z

No description provided.

- Moved `symbol.py` to `src/abyssal_tome/symbol.py`. - Consolidated constants by adding `wild` and `fast` to `src/abyssal_tome/constants.py`. - Updated `scripts/process_new_format.py` to import from `abyssal_tome.symbol`. - Restored missing `replace_special_tags` function body in `src/abyssal_tome/app.py`. - Fixed syntax errors in `scripts/process_new_format.py` (indentation) and `scripts/process_json.py` (docstrings/regex). - Updated `src/abyssal_tome/app.py` to use `constants` for Flet path/port and handle `clipman.init()` gracefully. - Fixed `tests/test_process_new_format.py` to work with current codebase (imports, models, enum). - Applied `ruff format` and `ruff check --fix` (including `UP` rules for type hints). - Added `scripts/__init__.py` to allow importing scripts in tests.

- Moved `symbol.py` to `src/abyssal_tome/symbol.py`. - Consolidated constants and regex patterns in `src/abyssal_tome/constants.py`. - Updated `src/abyssal_tome/app.py` to import constants and patterns from `constants.py`, fixing NameErrors. - Restored missing `replace_special_tags` function body in `src/abyssal_tome/app.py`. - Fixed syntax errors in `scripts/process_new_format.py` and `scripts/process_json.py`. - Updated `scripts/process_new_format.py` to use new import paths and list types. - Fixed `tests/test_process_new_format.py` to work with current codebase (imports, models). - Added `scripts/__init__.py` to facilitate testing. - Applied `ruff format` and `ruff check --fix` (including `UP` rules). - Removed accidental binary index files.

coderabbitai · 2025-11-29T12:02:02Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)

autoreview

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch refactor-imports-and-styling

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

Provide your own instructions using the high_level_summary_instructions setting.
Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

📝 Description — Summarize the main change in 50–60 words, explaining what was done.

📓 References — List relevant issues, discussions, documentation, or related PRs.

📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.

📊 Contributor Summary — Include a Markdown table showing contributions:
| Contributor | Lines Added | Lines Removed | Files Changed |

✔️ Additional Notes — Add any extra reviewer context.
Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

This PR refactors imports and applies consistent code formatting across the codebase. The main changes consolidate constants, remove unused imports, and apply Black-style formatting to improve code readability and maintainability.

Key changes:

Centralized TAG_TO_LETTER and regex patterns into constants.py to eliminate duplication
Removed unused imports (requests, open_dir, lists, sampled_from)
Applied Black-style multi-line formatting to long function signatures and calls
Updated test signatures to match new API (added parameters to process_ruling_html calls)

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
tests/test_replace_special_tags.py	Updated import path from main to abyssal_tome.app; reformatted assertion
tests/test_process_new_format.py	Removed unused hypothesis imports; updated test calls with new parameters; removed obsolete test function
src/abyssal_tome/symbol.py	Replaced local TAG_TO_LETTER with import from constants
src/abyssal_tome/model.py	Applied multi-line formatting to function signatures
src/abyssal_tome/constants.py	Added regex import and centralized TAG_TO_LETTER and pattern constants
src/abyssal_tome/app.py	Removed unused imports; moved patterns to constants; added clipman error handling; applied extensive multi-line formatting
scripts/process_new_format.py	Updated symbol imports to absolute path; commented out duplicate TAG_TO_LETTER
scripts/process_json.py	Fixed docstring formatting; removed duplicate code; improved indentation
scripts/enrich_rulings_ai.py	Reordered imports; simplified list conversions using sorted() directly on sets
process_json_to_SQLite.py	Added pathlib import; replaced open() with Path.open(); removed blank line

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-29T12:05:22Z

@@ -74,9 +74,9 @@ def test_replace_special_tags(
    spans = replace_special_tags(page, ruling_text)


The function replace_special_tags is async (as defined in src/abyssal_tome/app.py:183), but it's being called without await. This test function should be marked as async and use await when calling replace_special_tags, or use asyncio.run() to execute the async function.

Copilot · 2025-11-29T12:05:22Z

+    "fast": "j",
+    "wild": "z",


[nitpick] The keys 'fast' and 'wild' are added at the end of TAG_TO_LETTER dictionary, breaking alphabetical ordering. The dictionary was previously ordered with symbols like 'willpower', 'agility', 'combat', etc. in a logical grouping. Consider maintaining consistent ordering by placing these entries with their related groups or in alphabetical order.

Copilot · 2025-11-29T12:05:23Z

        combined_codes.discard(source_card_code)
-        return sorted(list(combined_codes))
-    return sorted(list(set(existing_related_codes)))
+        return sorted(combined_codes)


[nitpick] The simplified sorted(combined_codes) is correct since combined_codes is already a set. However, for consistency with line 77, consider making it explicit that you're sorting a set: sorted(list(combined_codes)). While not technically necessary, it makes the code more uniform and the intent clearer.

Suggested change

return sorted(combined_codes)

return sorted(list(combined_codes))

Copilot · 2025-11-29T12:05:23Z

-    
+
    Removes formatting artifacts, extracts FAQ references, reformats update timestamps, and determines the entry type (erratum, question/answer, or clarification). Returns a structured dictionary with cleaned content, source metadata, card name, and card code, or None if the ruling is empty or overruled.
+    """


The docstring is missing its closing triple quotes on a new line. The closing \"\"\" should be on line 91 (after the description), not line 90. Currently, line 90 has the closing quotes immediately after 'overruled.' which is inconsistent with the multi-line docstring format used elsewhere in this file and the codebase.

Copilot · 2025-11-29T12:05:23Z

        """
-        def _create_copy_button_lambda(btn_ruling_text, btn_ruling_question, btn_ruling_answer, btn_instance: ft.IconButton):
+
+        def _create_copy_button_lambda(


Variable _create_copy_button_lambda is not used.

Copilot · 2025-11-29T12:05:24Z

+        def _create_copy_button_lambda_for_card_view(
+            btn_ruling_text, btn_ruling_question, btn_ruling_answer, btn_instance: ft.IconButton
+        ):
+            rules_text_content = (
+                btn_ruling_text or rf"Q: {btn_ruling_question}\n A: {btn_ruling_answer}"
+            )
+            return lambda e: asyncio.create_task(
+                copy_ruling_to_clipboard(e, rules_text_content, btn_instance)
+            )



Variable _create_copy_button_lambda_for_card_view is not used.

Suggested change

def _create_copy_button_lambda_for_card_view(

btn_ruling_text, btn_ruling_question, btn_ruling_answer, btn_instance: ft.IconButton

):

rules_text_content = (

btn_ruling_text or rf"Q: {btn_ruling_question}\n A: {btn_ruling_answer}"

)

return lambda e: asyncio.create_task(

copy_ruling_to_clipboard(e, rules_text_content, btn_instance)

)

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2025-11-29T12:07:18Z

@@ -175,30 +159,94 @@ async def highlight_spans(text_spans: list[ft.TextSpan], search_term: str) -> li
    return highlighted_spans


Remove await on synchronous highlight_text

highlight_spans awaits highlight_text, but highlight_text is a normal function returning a list, not a coroutine. As soon as a search term triggers update_search_view and calls highlight_spans, Python raises TypeError: object list can't be used in 'await' expression, preventing any search results from rendering. Make highlight_text async or drop the await so searches can complete.

Useful? React with 👍 / 👎.

google-labs-jules bot added 3 commits November 29, 2025 11:00

Copilot AI review requested due to automatic review settings November 29, 2025 12:01

Copilot started reviewing on behalf of danelkay93 November 29, 2025 12:02 View session

Copilot finished reviewing on behalf of danelkay93 November 29, 2025 12:04

Copilot AI reviewed Nov 29, 2025

View reviewed changes

chatgpt-codex-connector bot reviewed Nov 29, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor imports and styling#14

Refactor imports and styling#14
danelkay93 wants to merge 3 commits intomasterfrom
refactor-imports-and-styling

danelkay93 commented Nov 29, 2025

Uh oh!

coderabbitai bot commented Nov 29, 2025

Review skipped

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 29, 2025

Uh oh!

Copilot AI Nov 29, 2025

Uh oh!

Copilot AI Nov 29, 2025

Uh oh!

Copilot AI Nov 29, 2025

Uh oh!

Copilot AI Nov 29, 2025

Uh oh!

Copilot AI Nov 29, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Uh oh!

chatgpt-codex-connector bot Nov 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -74,9 +74,9 @@ def test_replace_special_tags(
		spans = replace_special_tags(page, ruling_text)

	return sorted(combined_codes)
	return sorted(list(combined_codes))



		Removes formatting artifacts, extracts FAQ references, reformats update timestamps, and determines the entry type (erratum, question/answer, or clarification). Returns a structured dictionary with cleaned content, source metadata, card name, and card code, or None if the ruling is empty or overruled.
		"""

		@@ -175,30 +159,94 @@ async def highlight_spans(text_spans: list[ft.TextSpan], search_term: str) -> li
		return highlighted_spans

Conversation

danelkay93 commented Nov 29, 2025

Uh oh!

coderabbitai bot commented Nov 29, 2025

Review skipped

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Nov 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 29, 2025

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Nov 29, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants