-
Notifications
You must be signed in to change notification settings - Fork 29
Improve previewer crash recovery #578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.../main/kotlin/me/fornever/avaloniarider/idea/editor/actions/RunnableAssemblySelectorAction.kt
Outdated
Show resolved
Hide resolved
src/rider/main/kotlin/me/fornever/avaloniarider/previewer/AvaloniaPreviewerSessionController.kt
Outdated
Show resolved
Hide resolved
src/rider/main/kotlin/me/fornever/avaloniarider/previewer/AvaloniaPreviewerSessionController.kt
Outdated
Show resolved
Hide resolved
src/rider/main/kotlin/me/fornever/avaloniarider/previewer/AvaloniaPreviewerSessionController.kt
Outdated
Show resolved
Hide resolved
src/rider/main/kotlin/me/fornever/avaloniarider/previewer/AvaloniaPreviewerSessionController.kt
Outdated
Show resolved
Hide resolved
src/rider/main/kotlin/me/fornever/avaloniarider/previewer/AvaloniaPreviewerSessionController.kt
Outdated
Show resolved
Hide resolved
src/rider/main/kotlin/me/fornever/avaloniarider/previewer/AvaloniaPreviewerSessionController.kt
Outdated
Show resolved
Hide resolved
| @Volatile | ||
| private var lastProjectFilePath: Path? = null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please explain why is this field needed? Normally the project file path is immutable, it's set once and never changes (unless the project is renamed, or something? Are you targeting such cases?).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense; that field is gone now and we read the current projectFilePath directly from the property whenever we need it (e.g., when scheduling restarts), so there is no redundant state to keep in sync.
src/rider/main/kotlin/me/fornever/avaloniarider/previewer/AvaloniaPreviewerSessionController.kt
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
783564d to
88276bd
Compare
|
Hi @ForNeVeR! I've addressed the compilation error (missing type parameter on Side note: I noticed there's some pre-existing code duplication between |
This comment was marked as resolved.
This comment was marked as resolved.
756eec1 to
bb3c6f3
Compare
|
CI update: Windows and Ubuntu are now passing The macOS failure is unrelated to code changes - it's caused by a NuGet infrastructure issue: A re-run should fix it. |
bb3c6f3 to
c043619
Compare
1833c84 to
1660228
Compare
ForNeVeR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Improve stability when the previewer process crashes or cannot be started