Skip to content

Fix saving indirection for uint64 types #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kant2002 merged 1 commit into from
Feb 14, 2026
Merged

Fix saving indirection for uint64 types #952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Cesium.CodeGen.Tests/CodeGenPointersTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,12 @@ private static Task DoTest(string source)
[Fact]
public Task IndexOverPointer() => DoTest("void foo (int *x) { int y = x[1]; }");

[Fact]
public Task AssignToPointer() => DoTest(@"
void foo_int (int *x) { *x = 0; }
void foo_uint64 (unsigned long long *x) { *x = 0; }
");

[Fact]
public Task PointerToPointer() => DoTest("void foo (int **x) { int y = *x[1]; }");

Expand Down
11 changes: 11 additions & 0 deletions Cesium.CodeGen.Tests/verified/CodeGenPointersTests.AssignToPointer.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
System.Void <Module>::foo_int(System.Int32* x)
IL_0000: ldarg.0
IL_0001: ldc.i4.0
IL_0002: stind.i4
IL_0003: ret

System.Void <Module>::foo_uint64(System.UInt64* x)
IL_0000: ldarg.0
IL_0001: ldc.i4.0
IL_0002: stind.i8
IL_0003: ret
2 changes: 2 additions & 0 deletions Cesium.CodeGen/Ir/Types/PrimitiveType.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,8 @@ internal static class PrimitiveTypeInfo
{ PrimitiveTypeKind.Float, (OpCodes.Ldind_R4, OpCodes.Stind_R4) },
{ PrimitiveTypeKind.Long, (OpCodes.Ldind_I8, OpCodes.Stind_I8) },
{ PrimitiveTypeKind.UnsignedLong, (OpCodes.Ldind_I8, OpCodes.Stind_I8) },
{ PrimitiveTypeKind.LongLong, (OpCodes.Ldind_I8, OpCodes.Stind_I8) },
{ PrimitiveTypeKind.UnsignedLongLong, (OpCodes.Ldind_I8, OpCodes.Stind_I8) },
{ PrimitiveTypeKind.Double, (OpCodes.Ldind_R8, OpCodes.Stind_R8) },
{ PrimitiveTypeKind.Bool, (OpCodes.Ldind_I1, OpCodes.Stind_I1) },
};
Expand Down
Loading