[#928] Impl producing compiler error when required return is missing#958
Open
evgTSV wants to merge 2 commits intoForNeVeR:mainfrom
Open
[#928] Impl producing compiler error when required return is missing#958evgTSV wants to merge 2 commits intoForNeVeR:mainfrom
evgTSV wants to merge 2 commits intoForNeVeR:mainfrom
Conversation
… optimize codegen for constan values for if/else, while/do..while. Enhance do..while codegen. Improve the ConstantEvaluator. Add tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #928
Right now the compiler can handle missing returns. Moreover, it can evaluate the value of a conditional statement (if it's constant) to determine whether it's necessary or redundant in order to drop unreachable paths. As a result, codegen has become simpler.
Besides, I've reworked a sequence of statements in the do..while loop. This allowed for easier optimization of the generated code, since the statements are now in the proper order.
Also, there is a TODO: I assume we should evaluate NULL literals in the future.