Merged
Conversation
…tor to generate pseudo-random sequential ids. Replace rng in the particle generator. Fix tests.
ForNeVeR
requested changes
Nov 17, 2025
Comment on lines
31
to
41
| member _.NextFishId() = | ||
| idGenerator.GetFishId() | ||
| idGenerator.NextIdWithPrefix(FishId.prefix) |> FishId | ||
|
|
||
| member _.NextBombId() = | ||
| idGenerator.GetBombId() | ||
| idGenerator.NextIdWithPrefix(BombId.prefix) |> BombId | ||
|
|
||
| member _.NextBonusId() = | ||
| idGenerator.GetBonusId() | ||
| idGenerator.NextIdWithPrefix(BonusId.prefix) |> BonusId |
Owner
There was a problem hiding this comment.
Honestly I don't understand why these methods were introduced in the ReproducibleRandom class to begin with; they are not supposed to be random at all.
Let's not touch these and SequentialIdGenerator in this PR? I'll open a separate issue to move them out of this type.
The SequentialIdGenerator was supposed to be sequential, not random. Moreover, random by its very definition is not unique, and uniqueness is what we need from the identifiers.
Contributor
Author
There was a problem hiding this comment.
Ok, let's move it another PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement reproducible random (xoshiro256++), similar algorithm is used in dotnet.
Issue #276