Skip to content

feat: add "ECWC Standard" font#748

Open
Forceh91 wants to merge 88 commits intomainfrom
feat/add-official-font
Open

feat: add "ECWC Standard" font#748
Forceh91 wants to merge 88 commits intomainfrom
feat/add-official-font

Conversation

@Forceh91
Copy link
Owner

@Forceh91 Forceh91 commented May 6, 2024

An officially official font thanks to @djr/retro-env-can-weather-chan-fonts

Closes #1

Forceh91 and others added 30 commits April 22, 2024 17:26
…v-can-weather-chan into feat/add-official-font
@Forceh91
Copy link
Owner Author

Good to know! I think we're all set with the new font now right @wpgne / @djrrb ?

Pinging again @wpgne and @djrrb . Would love to get this merged now.

@djrrb
Copy link

djrrb commented Sep 3, 2025

So sorry for missing this thread, and thanks for pinging me @Forceh91 ! Let’s see if we can resolve this so you can finally merge.

Breaking down the comment from @andrew867 :

Something to look out for, there may be some layout issues with the new font as after watching for a while some text goes off the bottom of the centre area.

I think this is an example of this issue:

Screenshot 2025-09-02 at 10 08 32 PM

As far as I can tell, this is caused by extra linebreaks being added to the copy.

I don’t think the font is the culprit here, since if I overlay the broken layout above with a layout performing as expected, the baselines still line up, and the font isn’t doing anything differently.

Screenshot 2025-09-02 at 10 09 26 PM

So @Forceh91 I think removing those linebreaks should cause the issue. If you never want an empty vertical line, you could consider doing a find/replace for two linebreaks and replacing them with one?

Also the footer looks strange in small caps with the new font (not sure if intentional)

This is intentional, based on the original rendering of ECW. Here’s a still from 1998:
image

and in some browsers isn’t centered.

I’m not sure why this would be different browser to browser...I’d need to have more details/examples to know if this is something caused by the font.

FWIW, the final line was not centered in the reference image shown above, and is right-aligned with the first footer line. (It looks like it may have been rendered by a different system, since the monospace columns are not exactly the same...see the misalignment of E in Environmental and M in Time).

@wpgne can weigh in if he would like, but as far as I’m concerned feel free to right-align the final line and maybe we sidestep this issue altogether.

I’m not sure how far into the weeds you want to get, but you could also consider narrowing the footer as a whole, since it seems wider in the simulator than it does in the still...pink lines show original width:

Screenshot-2025-09-02-at-10 08 32-PM

Good to know! I think we're all set with the new font now right @wpgne / @djrrb ?

As far as I can see, nothing mentioned above would require changes to the font itself. So I’m happy to see it merged if all others are comfortable moving forward with it.

@Forceh91
Copy link
Owner Author

Forceh91 commented Sep 4, 2025

Breaking down the comment from @andrew867 :

Something to look out for, there may be some layout issues with the new font as after watching for a while some text goes off the bottom of the centre area.

I think this is an example of this issue:
Screenshot 2025-09-02 at 10 08 32 PM

As far as I can tell, this is caused by extra linebreaks being added to the copy.

I don’t think the font is the culprit here, since if I overlay the broken layout above with a layout performing as expected, the baselines still line up, and the font isn’t doing anything differently.
Screenshot 2025-09-02 at 10 09 26 PM

So @Forceh91 I think removing those linebreaks should cause the issue. If you never want an empty vertical line, you could consider doing a find/replace for two linebreaks and replacing them with one?

Also the footer looks strange in small caps with the new font (not sure if intentional)

This is intentional, based on the original rendering of ECW. Here’s a still from 1998:
image

and in some browsers isn’t centered.

I’m not sure why this would be different browser to browser...I’d need to have more details/examples to know if this is something caused by the font.

FWIW, the final line was not centered in the reference image shown above, and is right-aligned with the first footer line. (It looks like it may have been rendered by a different system, since the monospace columns are not exactly the same...see the misalignment of E in Environmental and M in Time).

@wpgne can weigh in if he would like, but as far as I’m concerned feel free to right-align the final line and maybe we sidestep this issue altogether.

Yeah this is something thats always persisted. Mostly down to the fact that the forecasts are automated now instead of handwritten for the channel itself. I've done my best to try and fit it into 32 chars/8 lines at once but sometimes the automated forecast just has too much info.

It's obviously more noticeable on the 2nd page of the forecast where it gives you the next two blocks of information.

I’m not sure how far into the weeds you want to get, but you could also consider narrowing the footer as a whole, since it seems wider in the simulator than it does in the still...pink lines show original width:
Screenshot-2025-09-02-at-10 08 32-PM

Good to know! I think we're all set with the new font now right @wpgne / @djrrb ?

As far as I can see, nothing mentioned above would require changes to the font itself. So I’m happy to see it merged if all others are comfortable moving forward with it.

Should be easy enough to do. The footer has always just kinda been thrown in without too much care 😅

@Forceh91 Forceh91 closed this Oct 21, 2025
@Forceh91 Forceh91 reopened this Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Font not accurate

3 participants