Added env variable to set a minium password length #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thank you very much for your contribution and please excuse the late reply! I fixed a couple of things in the code and made it non-persistent as well as still requiring at least 6 characters. Would that be okay with your use case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi, to use this awesome software ❤️ in production i needed to set a minium password length.
i removed the hardcoded value and added a env variable MIN_LENGTH_PASSWORD , this is also used in the setup process for the admin account.
first time working on go code , so i am sure i missed something.
let me know whats needs to be done and if the feature is wanted in master
thx so far