Skip to content

[fix] match vbeam parameters#22

Merged
charlesbmi merged 12 commits intomainfrom
fix/vbeam-match
Jul 3, 2025
Merged

[fix] match vbeam parameters#22
charlesbmi merged 12 commits intomainfrom
fix/vbeam-match

Conversation

@charlesbmi
Copy link
Copy Markdown
Collaborator

#4

Introduction

test_vbeam.py was visually matching but not numerically-perfectly matching.

Changes

  1. match up the apodization parameters properly
  2. add a single-transmit validation test

Behavior

  • update tests
  • no changes to package code

Review checklist

  • All existing tests and checks pass
  • Unit tests covering the new feature or bugfix have been added
  • The documentation has been updated if necessary

@charlesbmi charlesbmi self-assigned this Jul 2, 2025
@charlesbmi charlesbmi marked this pull request as draft July 3, 2025 03:00
@charlesbmi charlesbmi marked this pull request as ready for review July 3, 2025 03:00
@charlesbmi charlesbmi merged commit c59aafa into main Jul 3, 2025
8 checks passed
@charlesbmi charlesbmi deleted the fix/vbeam-match branch July 3, 2025 03:03
alexrockhill pushed a commit to alexrockhill/mach that referenced this pull request Aug 18, 2025
* Changes that seem to help with tolerance? double-check

* Add single-transmit test?

* Was missing a tukey-alpha=0 that was causing an issue

* FIx grid shape typo

* Fix the atol rtol issues

* Plot the difference map in db instead of fraction

* Fix lint

* Some cleanup

* Some cleanup

* Clean up some prints

* Minor fix

* More cleanup

---------

Co-authored-by: Charles Guan <3221512+charlesincharge@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant