[feature] tune block-size and grid-size for low-frame count#29
Merged
charlesbmi merged 5 commits intomainfrom Jul 7, 2025
Merged
[feature] tune block-size and grid-size for low-frame count#29charlesbmi merged 5 commits intomainfrom
charlesbmi merged 5 commits intomainfrom
Conversation
alexrockhill
pushed a commit
to alexrockhill/mach
that referenced
this pull request
Aug 18, 2025
…eurotech#29) * Increase the number of blocks for low n_frames * Some changes that I think work, but are a bit confusing * Remove 64x frames because that is not aprt of the plan * Factor out some helper functions * fix lint --------- Co-authored-by: Charles Guan <3221512+charlesincharge@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction
Currently kernel is optimized for ensemble images (e.g. ~32-400 frames). frames=1 was not really considered
Changes
Make some low-hanging changes to just the small frame_count to make it use all threads that we would have (i.e. at least 32)
Behavior
faster for n_frames=1, by about 4x
Review checklist