[maint] use complex64 in PyMUST to match the GPU implementations#31
Merged
charlesbmi merged 1 commit intomainfrom Jul 9, 2025
Merged
[maint] use complex64 in PyMUST to match the GPU implementations#31charlesbmi merged 1 commit intomainfrom
charlesbmi merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction
GPU implementations use complex64 precision by default. This does affect runtime (mostly because of memory access)
Changes
Behavior
Did not update the benchmark figure yet because
vbeamseems to have slowed down, so I'll track down where that comes from (or maybe the previous benchmarks were unexpectedly fast)?Review checklist