Skip to content

fix: force include all foreign keys #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −1
Open

fix: force include all foreign keys #748

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5056c99
fix: polymorphic associations by including all belongs_to foreign keys
matthv Jul 22, 2025
f53a5bf
fix: uniq keys
matthv Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/forest_liana/active_record_override.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def apply_column_aliases(relation)
keys = [join_part.base_klass.primary_key] # Always include the primary key

# # %%% Optional to include all foreign keys:
# keys.concat(join_part.base_klass.reflect_on_all_associations.select { |a| a.belongs_to? }.map(&:foreign_key))
keys.concat(join_part.base_klass.reflect_on_all_associations.select { |a| a.belongs_to? }.map(&:foreign_key)).compact.uniq
# Add foreign keys out to referenced tables that we belongs_to
join_part.children.each { |child| keys << child.reflection.foreign_key if child.reflection.belongs_to? }

Expand Down
Loading