Skip to content

Conversation

@Leymooo
Copy link
Contributor

@Leymooo Leymooo commented Oct 1, 2016

#3

@FormallyMyles
Copy link
Owner

This won't fix the issue, the issue is the SKIN data is decoded to "{textures:{SKIN:{url:"http://textures.minecraft.net/texture/1ff33de8876e3cdd89ae81835f3affc946bc498393c3644cfa04b6a6c89d2fd"}}}"

There is missing quotes causing json not to read it and i'm yet to find a decent way / library to handle this.

@Leymooo
Copy link
Contributor Author

Leymooo commented Oct 1, 2016

This will be work?

@FormallyMyles
Copy link
Owner

That would make it fail to prevent the exploit.

@Leymooo
Copy link
Contributor Author

Leymooo commented Oct 1, 2016

but this work.

http://pastebin.com/0r5uibFy

@FormallyMyles
Copy link
Owner

This still doesn't check for valid json (which is the issue I see), well valid mojangson.

And also does this run into issues with ProtocolLib not decoding the NBT properly still? (It was an issue I faced which is why I don't support 1.10)

@Leymooo
Copy link
Contributor Author

Leymooo commented Nov 2, 2016

Why you need to check json? I think cheathers can't make "url" or "skin" with null value.

@FormallyMyles
Copy link
Owner

@Dimatert9
Because it's much cleaner?

And not checking that could just allow people to spoof values to satisfy this plugin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants