-
Notifications
You must be signed in to change notification settings - Fork 9
fix decode #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix decode #7
Conversation
|
This won't fix the issue, the issue is the SKIN data is decoded to "{textures:{SKIN:{url:"http://textures.minecraft.net/texture/1ff33de8876e3cdd89ae81835f3affc946bc498393c3644cfa04b6a6c89d2fd"}}}" There is missing quotes causing json not to read it and i'm yet to find a decent way / library to handle this. |
|
This will be work? |
|
That would make it fail to prevent the exploit. |
|
but this work. |
|
This still doesn't check for valid json (which is the issue I see), well valid mojangson. And also does this run into issues with ProtocolLib not decoding the NBT properly still? (It was an issue I faced which is why I don't support 1.10) |
|
Why you need to check json? I think cheathers can't make "url" or "skin" with null value. |
|
@Dimatert9 And not checking that could just allow people to spoof values to satisfy this plugin? |
#3