ingestion analytics initial code completed (to be tested) #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| tags: Dict, | ||
| ): | ||
|
|
||
| self.ingestion_analytics.log_received_message(topic) |
There was a problem hiding this comment.
Lets log the received message from the ROS code that actually receives the ROS message BasicSubscriberCoodinater i think
| ): | ||
|
|
||
| self.ingestion_analytics.log_received_message(topic) | ||
| self.ingestion_analytics.log_sent_message(formant_stream) |
There was a problem hiding this comment.
Let's only log a sent message directly after the fclient._post_<type> calls to ensure its actually sent
Comment on lines
32
to
34
| def remove_sent_message(self, stream): | ||
| if stream in self.sent_messages_count and self.sent_messages_count[stream] > 0: | ||
| self.sent_messages_count[stream] -= 1 |
There was a problem hiding this comment.
we should never need this
|
|
||
| def reporting_loop(self): | ||
| while self.enabled: | ||
| self.report() |
There was a problem hiding this comment.
lets clear them out after we print
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.