Fix vite webpack node polyfills #233
Merged
+5,930
−6,061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amir Nathoo <[email protected]>
Signed-off-by: Amir Nathoo <[email protected]>
amirna2
requested review from
AaronGBoswell,
vahagn-yavruyan and
ranaya-formant
Signed-off-by: Amir Nathoo <[email protected]>
Signed-off-by: Amir Nathoo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements to the
examples/realtime-videoproject, primarily focused on adding Node.js polyfills for browser compatibility and enhancing development workflows. The main changes include updating dependencies, adding polyfills for Node.js globals, and expanding the Makefile with more granular commands.Polyfill and Dependency Updates:
setImmediateandclearImmediateinsrc/polyfills.ts, and ensured it loads at app startup viasrc/main.tsx. This improves compatibility when using Node.js-style asynchronous APIs in the browser. [1] [2]package.jsondependencies: bumped@formant/data-sdkto^1.80.8, addedprocessandsetimmediatepackages, and includedvite-plugin-node-polyfillsfor broader Node.js compatibility.vite.config.tsto usevite-plugin-node-polyfills, enabling polyfills for Node.js globals likeprocess,Buffer, and timers (setImmediate,clearImmediate).Development Workflow Enhancements:
Makefilewith new commands (clean,install,clean-install,local-dev,local-build,local-preview,deploy-prep,deploy-with-upstream) to streamline local development, building, and deployment processes.