Skip to content

Changed response stream to ros.services.response for all data returne… #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Changed response stream to ros.services.response for all data returne… #32

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8496ac
Changed response stream to ros.services.response for all data returne…
franklinv77 Jul 7, 2022
ca87147
Added tagging for ingestion
franklinv77 Jul 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions examples/ros-service-call-adapter/adapter/adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,11 +90,11 @@ def _handle_service_call(self, service_name: str, service_args: List[str]):

def _post_service_data(self, service_name: str, data: str):
"""Post's a string to Formant given the service_name string."""
stream_name = rospy.resolve_name(service_name).replace("/", ".")
stream_name = stream_name[1:] if stream_name[0] == "." else stream_name
response_stream = f"ros.service.{stream_name}.response"
# stream_name = rospy.resolve_name(service_name).replace("/", ".")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove dead code

# stream_name = stream_name[1:] if stream_name[0] == "." else stream_name
response_stream = f"ros.services.response"
try:
self._fclient.post_text(response_stream, str(data))
self._fclient.post_text(stream=response_stream, value=str(data), tags={"ros_service":service_name})
except Exception:
logger.info("Failed to post response")
return
Expand Down