This repository was archived by the owner on Feb 19, 2022. It is now read-only.
Don't hardcode the server's hostname#35
Open
MarkRedeman wants to merge 1 commit intoFormidableLabs:masterfrom
Open
Don't hardcode the server's hostname#35MarkRedeman wants to merge 1 commit intoFormidableLabs:masterfrom
MarkRedeman wants to merge 1 commit intoFormidableLabs:masterfrom
Conversation
This fixes a usability bug where the server is run inside of a Docker container (and probably also when inside of VM?). Since the container is run on a different IP the server wouldn't listen to any incoming requests. This does come with the downside that the server will now accept connections on any IP address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a usability bug where the server is run inside of a Docker container (and probably also when inside of VM?). Since the container is run on a different IP the server wouldn't listen to any incoming requests.
This does come with the downside that the server will now accept connections on any IP address.
In case anyone is interested, this is the
docker-compose.ymlfile that I'm using to install and serve my slides: