feat: added semantic token concept interactive surface (refs SFKUI-6500)#1078
Merged
feat: added semantic token concept interactive surface (refs SFKUI-6500)#1078
Conversation
jaken22
requested review from
MCFK,
NicklasWei,
TMFKse,
atfkassan,
dvitamin,
ext,
jameseklund,
jensviklander and
udenius
as code owners
CHANGELOGBased on commits in this Pull Request this will create a minor release and the following entries will be added to the changelog: Features
If this is not correct you can amend the commit message(s). Read more about the release process (swedish). |
Artifact sizesArtifact sizes in this build (unchanged artifacts collapsed below).
6 unchanged artifacts
|
Förhandsgranskning 🐛 🔍Dokumentation och exampel applikationer finns att förhandsgranska på: Senast uppdaterad 2026-03-09 12:19 UTC i gh-pages. |
jaken22
force-pushed
the
feat/interactive-surface-tokens
branch
2 times, most recently
from
5c9c332 to
f4ce0a0
Compare
dvitamin
approved these changes
Mar 9, 2026
MCFK
approved these changes
Mar 9, 2026
jensviklander
approved these changes
Mar 9, 2026
johancarnegard
approved these changes
Mar 9, 2026
ext
approved these changes
Mar 9, 2026
Contributor
ext
left a comment
ext
left a comment
There was a problem hiding this comment.
Intressant, tycker det låter som en bra idé
jaken22
force-pushed
the
feat/interactive-surface-tokens
branch
from
7f4f416 to
5c9c332
Compare
jaken22
force-pushed
the
feat/interactive-surface-tokens
branch
from
5c9c332 to
28f12ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Från början använde vi oss av konceptet active på alla interagerbara komponenter. Detta utökades sedan med select för att hantera inmatningskomponenter. För att ytterligare förbättra semantiken inför vi nu konceptet interactive surface som till en början används på expanderbar panel. Detta krävs också för att hantera hover state i dark mode på expandera panelen.
Totalt fyra nya tokens införda:
--fkds-color-interactive-surface-background-primary-default
--fkds-color-interactive-surface-background-primary-hover
--fkds-color-interactive-surface-background-primary-active
--fkds-color-interactive-surface-background-primary-focus
Komponenten FExpandablePanel uppdaterad med nya tokens:
$expandablepanel-heading-color-background-default: var(--fkds-color-interactive-surface-background-primary-default) !default;
$expandablepanel-heading-color-background-hover: var(--fkds-color-interactive-surface-background-primary-hover) !default;