Skip to content

[WIP] fix: fix FSortFilterDataset clear button alignment (fixes SFKUI-7538)#1082

Draft
NicklasWei wants to merge 2 commits intomainfrom
fsortfilter-search
Draft

[WIP] fix: fix FSortFilterDataset clear button alignment (fixes SFKUI-7538)#1082
NicklasWei wants to merge 2 commits intomainfrom
fsortfilter-search

Conversation

@NicklasWei
Copy link
Contributor

@NicklasWei NicklasWei commented Mar 8, 2026 •
edited
Loading

Byter ut custom sök/filter textfält i FSortFilterDataset till FSearchTextField och löser därav också att knappen för att tömma fältet inte var rätt placerad.

Öppnar som draft så UX kan kolla på det först.

Se sandbox för test: https://forsakringskassan.github.io/designsystem/pr-preview/pr-1082/vue-sandbox/#/
Datamängdsorterare: https://forsakringskassan.github.io/designsystem/pr-preview/pr-1082/components/table-and-list/fsortfilterdataset.html

Todo:

  • Återställ sandbox

@NicklasWei NicklasWei self-assigned this Mar 8, 2026
@NicklasWei NicklasWei added the work in progress Someone is working on this issue label Mar 8, 2026
NicklasWei
NicklasWei commented Mar 8, 2026
View reviewed changes
packages/vue/src/components/FTextField/extendedTextFields/FSearchTextField/FSearchTextField.vue
],
data() {
return {
defaultText: this.$t("fkui.search-text-field.label", "Sök"),
Copy link
Contributor Author

@NicklasWei NicklasWei Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Osäker varför men fick this.$t is not a function från FSortFilterDataset.spec.ts av denna raden så skiftade till TranslationService.provider.translate som jag såg vissa andra textnycklar använde, vilket verkade lösa det.

@NicklasWei NicklasWei force-pushed the fsortfilter-search branch from ed83bf1 to a219f74 Compare March 8, 2026 20:52
@github-actions
Copy link

github-actions bot commented Mar 8, 2026 •
edited
Loading

CHANGELOG

Based on commits in this Pull Request this will create a patch release and the following entries will be added to the changelog:

Bug Fixes

  • fix `FSortFilterDataset` clear button alignment (fixes SFKUI-7538) af51cfe

If this is not correct you can amend the commit message(s).

Read more about the release process (swedish).

@github-actions
Copy link

github-actions bot commented Mar 8, 2026 •
edited
Loading

Artifact sizes

Artifact sizes in this build (unchanged artifacts collapsed below).

Artifact Files Size Change
@fkui/date (esm) 1 file(s) 32.2KiB → 32.2KiB (-35B) -0.11%
@fkui/design 2 file(s) 187.8KiB → 186.8KiB (-967B) -0.50%
@fkui/logic (esm) 1 file(s) 162.3KiB → 161.9KiB (-349B) -0.21%
@fkui/vue (esm) 1 file(s) 1.0MiB → 1.0MiB (-6.8KiB) -0.64%
@fkui/vue (FBadge bundle) 1 file(s) 550.5KiB → 546.8KiB (-3.7KiB) -0.67%
@fkui/vue/cypress 1 file(s) 56.0KiB → 55.8KiB (-112B) -0.20%
@fkui/vue-labs (esm) 1 file(s) 249.9KiB → 248.3KiB (-1.7KiB) -0.66%
1 unchanged artifact
Artifact Files Size
@fkui/vue/selectors 1 file(s) 3.3KiB

@github-actions
Copy link

github-actions bot commented Mar 8, 2026 •
edited
Loading

Förhandsgranskning 🐛 🔍

Dokumentation och exampel applikationer finns att förhandsgranska på:

Sida URL
Dokumentation https://Forsakringskassan.github.io/designsystem/pr-preview/pr-1082/
Vue Sandbox https://Forsakringskassan.github.io/designsystem/pr-preview/pr-1082/vue-sandbox
Applikationsmall https://Forsakringskassan.github.io/designsystem/pr-preview/pr-1082/examples/page-layout
Senast uppdaterad 2026-03-09 10:48 UTC i gh-pages.

@NicklasWei NicklasWei force-pushed the fsortfilter-search branch from a219f74 to c800e72 Compare March 8, 2026 21:14
@NicklasWei NicklasWei force-pushed the fsortfilter-search branch from c800e72 to 17a6f6a Compare March 9, 2026 10:43
ext
ext reviewed Mar 9, 2026
View reviewed changes
packages/vue/src/components/FSortFilterDataset/FSortFilterDataset.vue
showFilter?: boolean;
/**
* Set placeholder text in filter input field.
* Set text in filter input field label.
Copy link
Contributor

@ext ext Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vi ska inte införa en ny prop istället? Och deprekera den här?

Kan det inte bli konstigt om jag har:

<f-sort-filter-dataset placeholder-filter="Skriv in texten du vill filtrera på" />

Om det nu blir etiketten helt plötsligt så kan det väl bryta designen ganska mycket iom att den etiketten knappast får plats?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ext ext ext left review comments

@atfkassan atfkassan Awaiting requested review from atfkassan atfkassan will be requested when the pull request is marked ready for review atfkassan is a code owner

@dvitamin dvitamin Awaiting requested review from dvitamin dvitamin will be requested when the pull request is marked ready for review dvitamin is a code owner

@MCFK MCFK Awaiting requested review from MCFK MCFK will be requested when the pull request is marked ready for review MCFK is a code owner

@TMFKse TMFKse Awaiting requested review from TMFKse TMFKse will be requested when the pull request is marked ready for review TMFKse is a code owner

@jameseklund jameseklund Awaiting requested review from jameseklund jameseklund will be requested when the pull request is marked ready for review jameseklund is a code owner

@udenius udenius Awaiting requested review from udenius udenius will be requested when the pull request is marked ready for review udenius is a code owner

@jensviklander jensviklander Awaiting requested review from jensviklander jensviklander will be requested when the pull request is marked ready for review jensviklander is a code owner

Assignees

@NicklasWei NicklasWei

Labels

work in progress Someone is working on this issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NicklasWei @ext