refactor: add pagination example (refs SFKUI-7692)#1088
Conversation
jensviklander
requested review from
MCFK,
NicklasWei,
TMFKse,
atfkassan,
dvitamin,
ext,
jameseklund and
udenius
as code owners
CHANGELOGNo commits contributing to a release was found, no changelog entries will be added for this Pull Request. If this PR should be included in a release amend the commit message(s) to use:
Read more about the release process (swedish). |
Artifact sizesNo artifact size changes in this build. |
Förhandsgranskning 🐛 🔍Dokumentation och exampel applikationer finns att förhandsgranska på: Senast uppdaterad 2026-03-11 14:01 UTC i gh-pages. |
| key: "name", | ||
| editable: true, | ||
| label: (row) => `Namn för rad ${row.id}`, | ||
| value(row) { |
There was a problem hiding this comment.
value och update behöver inte specificeras när key redan används.
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
cat packages/vue-labs/src/components/FTable/examples/FTablePaginationExample.vue
Length of output: 5296
@dvitamin, here is the fix — removing the redundant value and update callbacks from the two columns that already specify a key:
- Remove
valueandupdatefrom thenamecolumn (already haskey: "name") - Remove
valuefrom thereceivedAtcolumn (already haskey: "receivedAt")
💡 Use @coderabbitai plan to create a plan for code changes
There was a problem hiding this comment.
Caution
CodeRabbit could not initialize plan tracking. Please try again later.
| rows.value = rows.value.filter((row) => !selectedRows.value.includes(row)); | ||
| } | ||
|
|
||
| function asRows(value: Row[]): Row[] { |
There was a problem hiding this comment.
Denna känns lite tråkig att behöva, konstigt typningen inte följer med.
There was a problem hiding this comment.
Bra att du såg den, tror faktiskt att det går bra att städa bort den. Är gammalt skräp från när jag försökte få till pagineringen där den tappade typningen, men borde fungera utan den nu 👍
3 participants
No description provided.